Add Docker build script #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dezren39
force-pushed
the
add-build-script
branch
from
59fd091 to
5435651
Compare
* update comments * rename to beepy * Create Dockerfile * Update dbuild.sh * Create lib.sh * improve * Update and rename initialize-repo.sh to initialize-submodules.sh * reset submodules * +x * improve init * reset * build * rename * init when needed * improve readme * improve scripts * Delete Dockerfile
dezren39
force-pushed
the
add-build-script
branch
from
5435651 to
a7e32ab
Compare
* update comments * rename to beepy * Create Dockerfile * Update dbuild.sh * Create lib.sh * improve * Update and rename initialize-repo.sh to initialize-submodules.sh * reset submodules * +x * improve init * reset * build * rename * init when needed * improve readme * improve scripts * Delete Dockerfile
dezren39
force-pushed
the
add-build-script
branch
from
a7e32ab to
611b17a
Compare
…c_puppet into add-build-script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also provided some supporting scripts for those who are less familiar with submodules.
One with git+docker should be able to quick start build with the following:
Major thanks to @DJFliX for his work in the following upstream PR:
solderparty#16
https://github.com/DJFliX/bbq20kbd/tree/docker-build-script
His build image has been very useful. BTW, I intend to investigate a PR adding the backlight timeout from his other PR soon.
solderparty#17
https://github.com/DJFliX/bbq20kbd/tree/add-backlight-dimming
After that we will see if I have any energy left for documenting the keymap etc. Maybe I will look to see if there is a nice way to incorporate a couple more bindings, specifically delete would be nice. I may take hints from DJFliX again, he had some pretty good ideas.
BTW there seems to be a keyboard driver bug where unpresses and presses are missed. I'm not sure if that is in upstream or a regression for beepy. Should all issues go to beepy issue tracker? Or where? Missed press is fine, just re-click the button, but the missed unpress is quite annoying, spamming characters or spamming delete. :(