Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip registry creation on Snowflake when necessary #853

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

theory
Copy link
Collaborator

@theory theory commented Jan 3, 2025

In some cases, the Sqitch user will lack permission to create a schema, such as when the DBA doesn't want to give it that permission. Implement run_upgrade in the Snowflake engine to detect this lack of permission by executing CREATE SCHEMA IF NOT EXISTS and stripping out CREATE SCHEMA and COMMENT ON SCHEMA commands when it fails due to insufficient privileges. Resolves #828.

In some cases, the Sqitch user will lack permission to create a schema,
such as when the DBA doesn't want to give it that permission. Implement
`run_upgrade` in the Snowflake engine to detect this lack of permission
by executing `CREATE SCHEMA IF NOT EXISTS` and stripping out `CREATE
SCHEMA` and `COMMENT ON SCHEMA` commands when it fails due to
insufficient privileges. Resolves #828.
Copy link
Contributor

@autarch autarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@theory theory merged commit 33291bd into issue-824-mysql Jan 4, 2025
369 checks passed
@theory theory deleted the issue-828-snowflake branch January 4, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior when deploy script is missing
2 participants