Basic error message tests with bug reproduction

[brody4hire]

These tests reproduce a couple an issues I discovered from testing my Cordova plugin:

• In case of nonsense singe-word SQL statements such as "101" or "false" SQLCipher for Android throws StringIndexOutOfBoundsException with a nonsense error message. no longer an issue in 3.5.5 release
• While newer versions of the AOSP SQLite database classes include the SQLite error code in the error messages SQLCipher for Android only includes the error code in very specific cases such as a constraint violation.

For the Cordova plugin I will probably just add a quick fix to deal with the nonsense SQL case. (no longer needed)

[developernotes]

Hi @brodybits,

Thanks for looking into this further. I wonder if it would be beneficial to use the setMessage(…) function available within the SQLCipherTest class as a means to further communicate helpful information regarding a failure case? This will cause the test row within the suite to display the message below the test name/status. Thoughts?

[brody4hire]

I just updated this PR to use setMessage to show the actual exception messages. Unfortunately some of these messages do not fit on a normal mobile device in portrait mode. When I switch between portrait and landscape mode the output is cleared and then I would have to rerun the test suite to get the output again.

I hope this is helpful. I don't know if I will work on a fix anytime soon.

[brody4hire]

@developernotes I just rebased and made some minor updates. These tests reproduce sqlcipher/android-database-sqlcipher#295 and sqlcipher/android-database-sqlcipher#296 that I just raised. The reported messages are displayed by the test runner as well. Can you guys merge this one?

[developernotes]

Hi @brodybits

We've just released a new version of SQLCipher for Android 3.4.1, and an update to SQLCipher for Android. We will take a look at this and get back to you. Thanks!

[brody4hire]

I just updated this according to the actual behavior of 3.5.5:

• rawQuery with nonsense SQL statement throws StringIndexOutOfBoundsException android-database-sqlcipher#295 is no longer an issue; correct SQLiteException is thrown in case of nonsense SQL such as "101" or "false"
• Inconsistent error messages android-database-sqlcipher#296 (incorrect error messages) is still an issue

As an extra note the PRAGMA cipher_version and "Verify Cipher Provider Version" tests still need to be updated.

[developernotes]

Hi @brodybits

I have just uploaded the adjusted tests for cipher_version, cipher_provider, and the corresponding binaries. I will close this ticket, we can continue the discussion regarding #296 within that issue. Thanks!

[developernotes]

Hi @brodybits

Thanks for this, I've just merged it in!

[brody4hire]

On Feb 15, 2017 3:56 PM, "Nick Parker" ***@***.***> wrote: Merged #16.

Thanks for merging:)