Test results action #3087
Test results action #3087
Conversation
eygraber
force-pushed
the
test-results-action
branch
from
cfac3a9 to
c286e22
Compare
|
I mean even if it aggregates and has a nicer display for the compiler and gradle plugin tests which are JVM only that will be 99% of test failures on CI. All the multiplatform libs are mega stable, and you would still be able to find the original error report in the normal logs. If it's impossible to only aggregate some of the reports than yea probably nothing we can do |
|
It should be able to aggregate the compiler and gradle plugin tests. I'll try that now. |
eygraber
force-pushed
the
test-results-action
branch
from
c286e22 to
78f7d0b
Compare
|
Looks like it should work, but running into mikepenz/action-junit-report#23 |
|
according to their docs it should be using the github token by default |
|
Right, but I think that because the PR is coming from my fork it gets a read only token, so it can't write any of the annotations or checks. |
|
Yeah you need to exclude the step from running on forks |
eygraber
force-pushed
the
test-results-action
branch
from
78f7d0b to
d72f3b0
Compare
|
guess we'll see how it looks with the next failure in cash |
| @@ -91,5 +91,11 @@ jobs: | |||
| name: error-report | |||
| path: build-reports.zip | |||
|
|
|||
| - name: Publish Test Report | |||
| uses: mikepenz/action-junit-report@v3 | |||
| if: github.repository_owner == 'cashapp' # always run even if the previous step fails | |||
There was a problem hiding this comment.
Comment doesn't match the key/value pair. Are we missing if: ${{ always() }}?
There was a problem hiding this comment.
Or is that what you replaced?
There was a problem hiding this comment.
Ah yeah that got replaced.
I guess the comment should be:
# always run even if the previous step fails if the source is from the cashapp org
Closes #3075
Testing things out@AlecStrong @JakeWharton looks like this might not be as useful because of https://youtrack.jetbrains.com/issue/KT-32608
Any thoughts / ideas?