certstrap: Get rid of vendoring #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that certstrap is built on go1.11 with modules support, we don't need to keep these around. We also don't need to establish a go environment as subfolder for building.
|
|
Build relative to the work dir, rather than relying on go path and includes host components required for building direct and transitive dependencies.
Tries to build a docker image from the docker file during CI.
|
I think we'd like to keep vendoring around for the near future, until the ecosystem matures a bit |
|
I agree. Go modules will be turned on by default in Go 1.13, so let's wait at least until then. |
|
Sounds like a plan 👍 |
|
@defer if you're still interested, now is probably a good time to dust off your PR and get rid off vendoring :) |
|
#93 removed vendorized deps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that certstrap is built on go1.11 with modules support, we don't
need to keep these around. We also don't need to establish a go
environment as subfolder for building.