Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockResponse socketPolicy awkwardness in 4.0 #5199

Closed
yschimke opened this issue Jun 19, 2019 · 4 comments · Fixed by #5676
Closed

MockResponse socketPolicy awkwardness in 4.0 #5199

yschimke opened this issue Jun 19, 2019 · 4 comments · Fixed by #5676
Labels
bug Bug in existing code
Milestone
4.3

Comments

@yschimke
Copy link
Collaborator

One is deprecated, the other doesn't compile...

image
@yschimke yschimke added the bug Bug in existing code label Jun 19, 2019
@swankjesse
Copy link
Collaborator

Ugh. Kotlin doesn't like mutators to return things.

@swankjesse swankjesse added this to the 4.0 milestone Jun 19, 2019
@swankjesse swankjesse modified the milestones: 4.0, 4.1 Jul 11, 2019
@swankjesse
Copy link
Collaborator

I assume Good Kotlin Style is .apply ?

@yschimke
Copy link
Collaborator Author

@swankjesse that doesn't help for Java callers.

@swankjesse swankjesse modified the milestones: 4.1, 4.2 Aug 12, 2019
@swankjesse swankjesse modified the milestones: 4.2, 4.3 Sep 11, 2019
@yschimke yschimke mentioned this issue Sep 19, 2019
Closed
@yschimke
Copy link
Collaborator Author

apply doesn't really help, see #5470

swankjesse pushed a commit that referenced this issue Dec 31, 2019
@squarejesse
Un-deprecate some setters for chaining from Java
9d2fe75 
Closes: #5199
swankjesse pushed a commit that referenced this issue Dec 31, 2019
@squarejesse
Un-deprecate some setters for chaining from Java
a2c0607 
Closes: #5199
@swankjesse swankjesse mentioned this issue Dec 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug in existing code
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Un-deprecate some setters for chaining from Java square/okhttp
2 participants
@swankjesse @yschimke