-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout for flaky test #5305
Conversation
@@ -286,7 +287,10 @@ public void timeoutFollowingRedirectOnNewConnection() throws Exception { | |||
} | |||
} | |||
|
|||
@Flaky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear it shouldn't be flaky after this PR, but this will record the events for every test run, so we can observe typical response times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
|
@@ -286,7 +287,10 @@ public void timeoutFollowingRedirectOnNewConnection() throws Exception { | |||
} | |||
} | |||
|
|||
@Flaky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Increasing the timeout which only has 250ms tolerance after inbuilt delays etc. Issue info is here #5304