Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for flaky test #5305

Merged
merged 2 commits into from
Aug 10, 2019
Merged

Increase timeout for flaky test #5305

merged 2 commits into from
Aug 10, 2019

Conversation

yschimke
Copy link
Collaborator

Increasing the timeout which only has 250ms tolerance after inbuilt delays etc. Issue info is here #5304

@@ -286,7 +287,10 @@ public void timeoutFollowingRedirectOnNewConnection() throws Exception {
}
}

@Flaky
Copy link
Collaborator Author

@yschimke yschimke Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear it shouldn't be flaky after this PR, but this will record the events for every test run, so we can observe typical response times.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@yschimke
Copy link
Collaborator Author

Passing run https://4456-5152285-gh.circle-artifacts.com/0/home/circleci/reports/okhttp/build/reports/tests/test/classes/okhttp3.WholeOperationTimeoutTest.html

Events (18)
[0 ms] callStart: Request{method=POST, url=http://localhost:52107/}
[0 ms] proxySelectStart: http://localhost:52107/
[0 ms] proxySelectEnd: [DIRECT]
[0 ms] dnsStart: localhost
[0 ms] dnsEnd: [localhost/127.0.0.1]
[0 ms] connectStart: localhost/127.0.0.1:52107 DIRECT
[0 ms] connectEnd: http/1.1
[0 ms] connectionAcquired: Connection{localhost:52107, proxy=DIRECT hostAddress=localhost/127.0.0.1:52107 cipherSuite=none protocol=http/1.1}
[0 ms] requestHeadersStart
[0 ms] requestHeadersEnd
[0 ms] requestBodyStart
[250 ms] requestBodyEnd: byteCount=6
[250 ms] responseHeadersStart
[500 ms] responseHeadersEnd: Response{protocol=http/1.1, code=200, message=OK, url=http://localhost:52107/}
[500 ms] responseBodyStart
[751 ms] responseBodyEnd: byteCount=65536
[751 ms] connectionReleased
[751 ms] callEnd

@yschimke yschimke requested a review from swankjesse August 2, 2019 05:39
@@ -286,7 +287,10 @@ public void timeoutFollowingRedirectOnNewConnection() throws Exception {
}
}

@Flaky
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@swankjesse swankjesse merged commit 609888f into square:master Aug 10, 2019
@yschimke yschimke deleted the flaky branch April 11, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants