Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky test assertion in ConnectionPoolTest #8667

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Feb 1, 2025

The assertion taskRunner.activeQueues() was commented out due to a race condition causing flaky tests. This ensures more consistent test results while the underlying issue is investigated.

It's trivial to turn it from flaky to permanently failing by adding delay such as printlns.

    assertThat(taskRunner.activeQueues()).isNotEmpty()
    val qq = taskRunner.activeQueues()
    println(qq)
    println(qq.first().activeTask)
    println(qq.first().scheduledTasks)
    assertThat(taskRunner.activeQueues()).isNotEmpty() <-- Fails here

The assertion `taskRunner.activeQueues()` was commented out due to a race condition causing flaky tests. This ensures more consistent test results while the underlying issue is investigated.
@yschimke yschimke requested a review from swankjesse February 1, 2025 15:35
@yschimke
Copy link
Collaborator Author

yschimke commented Feb 1, 2025

@swankjesse requesting post review

@yschimke yschimke merged commit 8d76074 into square:master Feb 1, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant