Make Flow.collectToSink public. #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
approved these changes
Feb 4, 2025
Vichy97
approved these changes
Feb 4, 2025
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zach-klippenstein
force-pushed
the
zachklipp/collectosink-public
branch
from
9cf5b11 to
8be3e0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use
runningSideEffectfor many of the things that we previously used workers for. Just running a side effect with a few coroutines should be way cheaper than running aWorkerfor each.