-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social plugin makes Mkdocs build crashing when system dependencies are not met #6817
Comments
Related issue: squidfunk#6817
Thanks for suggesting. Please see #6818 (comment) why we're not considering this. |
I agree that OSError shouldn't just out right crash during config load and I have written a comment in the PR. Here I would like to question:
I used the social plugin on Windows with success, installed with the recommended compiled MINGW version from the docs. What I mean to say is that if the writers were able to install Python and know how to run the Assuming the OSError gets fixed one could also add more validation in a hook that would detect any particular issue with CairoSVG installation and provide more explanation what to do. Perhaps this should also be handled in the plugin 🤔 |
Related issue: squidfunk#6817
Related issue: squidfunk#6817 Co-authored-by: Guts <[email protected]>
Related issue: squidfunk#6817 Co-authored-by: Guts <[email protected]>
* fix(social): CairoSVG OSError handling in social plugin Related issue: #6817 Co-authored-by: Guts <[email protected]> * feat(docs): Add troubleshooting guide for CairoSVG crash --------- Co-authored-by: Kamil Krzyśków <[email protected]> Co-authored-by: Guts <[email protected]> Co-authored-by: Martin Donath <[email protected]>
Context
Our Mkdocs website is collaborative and many of writers are using Windows without any ability to install the CairoSVG dependencies at system level (https://squidfunk.github.io/mkdocs-material/plugins/requirements/image-processing/#cairo-graphics).
Bug description
Expected behavior: try/except the exception raised by cairosvg and display a error, warning or even info message to inform that social cards have been disabled, but let the build going on.
Related links
Reproduction
Sorry I cant' generate a minimal reproduction since the build is failing. Still, here comes a manual zip: material-social-card-build-crash.zip
Steps to reproduce
Install:
Given this mkdocs.yml:
Running build:
Browser
No response
Before submitting
The text was updated successfully, but these errors were encountered: