Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file save regression in privacy plugin #7673

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix file save regression in privacy plugin #7673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/privacy/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def _patch(self, initiator: File):

# Replace callback
def replace(match: Match):
value = match.group(1)
value = match.group("url")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the issue was that replace was called on the self.assets_expr_map[extension] entry in the parent method, which we've changed so positional groups didn't always give reliable results.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for investigating and fixing!


# Map URL to canonical path
path = self._path_from_url(urlparse(value))
Expand Down