-
Notifications
You must be signed in to change notification settings - Fork 538
Current use of gopkg.in is impossible to use #380
Comments
You can simply clone master under
|
@osklyar thanks, that makes sense... They should definitely be part of the main readme |
I still find it jarring that one cannot simply grab master and go (so to speak). Seems like the gopkg.in should be reserved for stable/tagged releases and not for development/master/tip code |
I agree it is cumbersome, but I would not necessarily see a better option right now. How do other libraries do that? |
They just use normal branches and tagging and nothing like gopkg.in they leave it up to consumers to choose they dependency/version management of choice |
What problem is gopkg.in solving for this project that simple tags don't? |
I mean other projects that do use going.in? I would also recommend to release next version directly via a tag on github, but the current one is already elsewhere. |
I think projects used gopkg.in before 1.6 when vendoring support was added. Now I find projects are discontinuing it's use. see: go-kit/kit#197 |
We will continue using gopkg.in in the near future for v4. We'll switch to GitHub imports when go dep is ready, and that will probably be for go-git v5. Most of the go-git team develops by using git directly on Of course you can also use a vendoring tool as @osklyar suggests. |
You can't really use a vendoring tool... that's the problem. It's fine if you're developing go-git, but if you're trying to make changes to go-git and consume them in another library, it becomes painful. I use glide and it takes some work to get it to pull from my go path instead of the internet sometimes. |
@jdoklovic See my very first response: it is the counter example to your statement of "you can't really use a vendoring tool..." – fork and point |
Indeed that's the only way to be able to use the lib after v4 because if you try the "usual" ways, which are go getting:
edit: in fact the correct command is |
@gonzaloserrano @osklyar @smola not to beat a dead horse, but until the v4 branch is rebased with master, this is still impossible for me to consume. I understand how I can work around it locally, but I'm building a CLI tool that people can install using |
@jdoklovic v4.0.0-rc10 is out: https://github.com/src-d/go-git/releases/tag/v4.0.0-rc10 |
@smola awesome! thanks. |
@bzz @smola @mcuadros
I have no problem with gopkg.in, however, the way it's currently used in this project makes it difficult if not impossible to develop against.
The main problem is that master uses gopkg.in/v4 imports, yet the v4 branch is 30 commits behind master at the moment. This effectively means it's difficult to tell which code is actually being used and even hard to make any local changes and/or PRs.
I think it would be better if master only used github/src-d imports and reserve the gopkg.in for the versioned branches.
The text was updated successfully, but these errors were encountered: