This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: object, new Commit.Verify method #653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
Verify
function toCommit
object.Provided an armored key ring, it verifies the signature of the commit.
I've tried it on my local repositories passing an armored key ring and it works as expected. But couldn't write a passing test for it because when I set a custom
TreeHash
andParentHashes
, the commit hash becomes0000000000000000000000000000000000000000
. Maybe I can use an existing signed commit in the fixtures, provided signing public key? Need help with the test.Export an armored key ring:
fixes #605