Transform debugging scripts so that they can be used as libs easily #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hugo Mougard <[email protected]>
vmarkovtsev
reviewed
Sep 20, 2018
| except AttributeError: | ||
| def print_usage(_): | ||
| parser.print_usage() | ||
|
|
||
| handler = print_usage | ||
| return handler(args) | ||
| return handler(**vars(args)) |
There was a problem hiding this comment.
I don't see where vars comes from...
There was a problem hiding this comment.
it's to transform the argsparse.Namespace into a dict
There was a problem hiding this comment.
BTW @zurk this is a nice solution of our API problems in sourced-ml - just feed the args as kwargs.
There was a problem hiding this comment.
@m09 Yes but we do not import vars nor define that function, do we?
There was a problem hiding this comment.
Holy crap it's a built-in
There was a problem hiding this comment.
yeah it's similar to dir
vmarkovtsev
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.