-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small various fixes #112
Small various fixes #112
Conversation
@vanhauser-thc this PR reverts the dual minimization PR and fixes all of the duplicate seed issues:
Could you please take a quick look? |
I evaluated this too. the coverage I obtained was quite different between the two. have you looked into that? |
done with my first review :) |
Here are the differences I could see at first glance:
Doesn't look like a downgrade, and kind of looks like an upgrade in some places. |
the changes even use less lines of code :) good job! |
Fixes CI, #109, #110, #111.
Reverts parts of #107.