Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run only 1 sanitized binary #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

run only 1 sanitized binary #116

wants to merge 2 commits into from

Conversation

Ollrogge
Copy link
Collaborator

Currently, when fuzzing with multiple cores and ASAN enabled, we use the sanitized binary on all cores. This is unnecessary and degrades performance; instead, use the ASAN-compiled binary only on the first core.

Since we need two binaries for this, compile both a sanitized version and a not sanitized version if ASAN is enabled.

@louismerlin
Copy link
Collaborator

Super cool! Do you have any idea what the speedup is?

Copy link
Collaborator

@louismerlin louismerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some eprintln for "asan" before building the asan binary?

@Ollrogge
Copy link
Collaborator Author

Super cool! Do you have any idea what the speedup is?

No idea but I can / will measure :)

@Ollrogge
Copy link
Collaborator Author

Ollrogge commented Dec 20, 2024

Super cool! Do you have any idea what the speedup is?

Did some minimal benchmarking with the url example application. Running the fuzzer for 3 minutes I get:

1 core:

  • ASan: cummulative speed 6.000 execs / sec | best coverage: 2.71 %
  • No ASan: cummulative speed: 54016 execs/sec | best coverage: 8.92%

10 cores:

  • 10 ASan: cummulative speed 22.767 execs/sec | best coverage: 4.30 %
  • 1 ASan + 9 No ASan: cummulative speed 137.464 execs/sec | best coverage: 19.40%

So the speedup is quite drastic :)

Also added the eprintln.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants