Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a summary of our general Tech Infrastructure #93

Merged
merged 12 commits into from
Sep 18, 2021

Conversation

PeterJCLaw
Copy link
Member

This is deliberately fairly high level and I expect that it will probably remain relatively high level in favour of having detailed instructions closer to the code which actually controls the relevant setups.

@trickeydan
Copy link
Contributor

Infrastructure is not in the competition remit. Please consider submitting this documentation to the appropriate location, or limiting the scope to competition team infrastructure only. This is especially relevant as Kit specific infrastructure is likely to be deployed in the near-future.

There was an Infrastructure Team proposal flying around a while ago, might be best to wait until that is settled.

I'd request that this PR is not merged until this is settled. Content looks good from a brief glance.

Related: #92

@@ -0,0 +1,62 @@
# Overview

Student Robotics has a variety of infrastrcture in order to support its mission.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Student Robotics has a variety of infrastrcture in order to support its mission.
Student Robotics has a variety of infrastructure in order to support its goals.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixed in 24fe613. Is there a reason to change mission to goals?

docs/infrastructure/README.md Show resolved Hide resolved
docs/infrastructure/README.md Show resolved Hide resolved
docs/infrastructure/README.md Outdated Show resolved Hide resolved
docs/infrastructure/README.md Outdated Show resolved Hide resolved
docs/infrastructure/README.md Outdated Show resolved Hide resolved
docs/infrastructure/README.md Outdated Show resolved Hide resolved
docs/infrastructure/competitor-services.md Outdated Show resolved Hide resolved
@PeterJCLaw
Copy link
Member Author

Infrastructure is not in the competition remit.

This is true but irrelevant. The runbook is not and never has been exclusive to the Competition Team. I am not interested in having a discussion of remit on this PR.

PeterJCLaw and others added 3 commits February 13, 2021 19:49
Co-authored-by: Dan Trickey <[email protected]>
Co-authored-by: Dan Trickey <[email protected]>
Copy link
Contributor

@trickeydan trickeydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infrastructure is not in the competition remit.

This is true but irrelevant. The runbook is not and never has been exclusive to the Competition Team. I am not interested in having a discussion of remit on this PR.

It is a shame that we could not discuss this.

Requesting changes on the grounds that information not under remit of the competition team should not be committed to this documentation.

@PeterJCLaw
Copy link
Member Author

Infrastructure is not in the competition remit.

This is true but irrelevant. The runbook is not and never has been exclusive to the Competition Team. I am not interested in having a discussion of remit on this PR.

It is a shame that we could not discuss this.

To be clear: I am stating that we should not discuss this on this PR.

Requesting changes on the grounds that information not under remit of the competition team should not be committed to this documentation.

Unfortunately I'm not going to be able to help with your request here, because it is based on an incorrect premise. As noted, I am not interested in having a discussion of the remit of the runbook on this PR. If you would like to have a general a discussion of the remit of the runbook, I suggest opening an issue instead. However I would caution against expecting radical change quickly -- it was quite a surprise to many that the Kit Team believed that the runbook was a purely Competition Team edifice, especially when the runbook self-documents otherwise.

PeterJCLaw and others added 2 commits February 13, 2021 20:09
Co-authored-by: Dan Trickey <[email protected]>
This will need review as part of srobo#71,
though is hopefully useful enough for now.
At some point we'll need to work out how & where to outline exactly
who is responsible for what, but I'm opting not to do that for now.
@PeterJCLaw PeterJCLaw merged commit 4f222c5 into srobo:master Sep 18, 2021
@PeterJCLaw PeterJCLaw deleted the tech-infrastructure branch September 18, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants