Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the period schedules to match the published day schedule #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PeterJCLaw
Copy link
Member

No description provided.

@PeterJCLaw PeterJCLaw force-pushed the set-period-schedules branch from f2ca1a8 to 4a66594 Compare January 28, 2025 21:33
@@ -46,15 +46,33 @@ match_periods:
description: Virtual league
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does max_end_time do, particularly in relation to the virtual league? If we have 5 minute slots and with the potential for 29 matches for the virtual league, it would last 145 minutes, which is longer than the max_end_time allows

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also have this question for how it works with the other match periods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think the end times are all fine then, except potentially the virtual league one, but that could be changed on the day if needed I guess

- start_time: 2024-04-13 12:40:00+01:00
end_time: 2024-04-13 13:58:00+01:00
max_end_time: 2024-04-13 14:00:00+01:00
- start_time: 2024-04-12 11:20:00+01:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the first match (i.e. start buttons pressed) is at 11:20? Or is this when the shepherding starts? Or is this just when the slot begins and the first match is scheduled independently of this?

Copy link
Member Author

@PeterJCLaw PeterJCLaw Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is keyed from the match slots. Those are the full cycles which include (re)setting the arena, state recording (scoring) afterwards, etc. The datetimes in this file (including the "end" times) thus relate to the starts of slots. Shepherding may happen before the start of a slot, but is still keyed from it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, all the start times need to be 4 minutes later then so "start buttons pressed" is at 5 minutes after the league slot starts in the schedule. I've added suggestions to all of these times

- start_time: 2024-04-13 12:40:00+01:00
end_time: 2024-04-13 13:58:00+01:00
max_end_time: 2024-04-13 14:00:00+01:00
- start_time: 2024-04-12 11:20:00+01:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- start_time: 2024-04-12 11:20:00+01:00
- start_time: 2024-04-12 11:24:00+01:00

description: Saturday league, morning

#
- start_time: 2024-04-12 13:20:00+01:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- start_time: 2024-04-12 13:20:00+01:00
- start_time: 2024-04-12 13:24:00+01:00

description: Saturday league, early afternoon

#
- start_time: 2024-04-12 15:10:00+01:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- start_time: 2024-04-12 15:10:00+01:00
- start_time: 2024-04-12 15:14:00+01:00

description: Saturday league, late afternoon

#
- start_time: 2024-04-13 10:20:00+01:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- start_time: 2024-04-13 10:20:00+01:00
- start_time: 2024-04-13 10:24:00+01:00

#
knockout:
- start_time: 2024-04-14 14:15:00+01:00
end_time: 2024-04-14 15:53:00+01:00
- start_time: 2024-04-13 12:30:00+01:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- start_time: 2024-04-13 12:30:00+01:00
- start_time: 2024-04-13 12:34:00+01:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants