Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ssbc urls #336

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Migrate to ssbc urls #336

merged 4 commits into from
Nov 7, 2022

Conversation

decentral1se
Copy link
Member

@decentral1se decentral1se commented Oct 29, 2022 •
edited
Loading

Seems to be a bunch of test failures that need working out...

Closes #332.

@staltz
Copy link
Member

staltz commented Oct 31, 2022

So far the changes I see look reasonable and good, but we gotta figure out a solution for the test failures.

If you open Files changed you can see the test failures inlined in the diff, most of them seem to be related to ssb refs.

@decentral1se
Copy link
Member Author

Will bounce back to this once the dust settles on ssbc/go-ssb#183 🤓

@decentral1se decentral1se force-pushed the ssbc-urls branch 5 times, most recently from c123ef5 to d7fae8d Compare November 6, 2022 21:03
@decentral1se decentral1se changed the title wip: ssbc urls Migrate to ssbc urls Nov 6, 2022
@decentral1se
Copy link
Member Author

@mycognosist @staltz

The go-ssb-ref changes were kinda significant and probably require some API re-working on this side. But I don't really have that much time to dive into cleaning things up, so this is just the minimal "It Works" ™️ changes. Everything points to the github.com/ssbc/... namespace repos now, so I hope it will be easier to coordinate changes going forward.

staltz
staltz approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope.

This was a lot of code, but after scrolling a while it was obvious most changes look the same. I hope it works

@staltz staltz merged commit 00a1452 into ssbc:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to new ssbc urls
2 participants
@decentral1se @staltz