Log splicer rewrite #9
Conversation
cblgh
force-pushed
the
log-splicer-rewrite
branch
from
d43e8aa to
53495c6
Compare
cmd/log-splicer/main.go
Outdated
| @@ -20,9 +26,12 @@ import ( | |||
| "go.cryptoscope.co/margaret/legacyflumeoffset" | |||
| ) | |||
|
|
|||
| // TODO: collapse feedinfo + feedjson into just feedinfo? and use temp struct for unmarshaling ID? | |||
There was a problem hiding this comment.
i decided not to do this: feels cleaner the way it is, and the two data structures have their own priorities. FeedInfo collects FeedInfo, FeedJSON is used to persist feed mappings to json. the last one could maybe have a better name, but hey life is short
cmd/log-splicer/main.go
Outdated
| @@ -20,9 +26,12 @@ import ( | |||
| "go.cryptoscope.co/margaret/legacyflumeoffset" | |||
| ) | |||
|
|
|||
| // TODO: collapse feedinfo + feedjson into just feedinfo? and use temp struct for unmarshaling ID? | |||
| // * Maps identities to folder names they live in | ||
| // * Copies secrets from the fixtures folder to each identity folder | ||
| // * Splics out messages from the one ssb-fixtures log.offset to the many log.offset in said folder structure | ||
| // * Persists an identity mapping of ID to {folderName, latest sequence number} to secret-ids.json |
There was a problem hiding this comment.
This is a meta comment about using markdown lists, which sadly fails horribly.
here are some options: https://stackoverflow.com/a/52745058
(ps: If you like, you could subscribe to golang/go#7873)
There was a problem hiding this comment.
I made a modified version of Godoc that adds ordered and unordered lists with a fast and simple custom parser I wrote called slippery-slope-markdown.
🤣
cmd/log-splicer/main.go
Outdated
|
|
||
| _, err = a.log.Append(v) | ||
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "failed to write entry to output log %s: %s\n", logPaths[1], err) | ||
| fmt.Fprintf(os.Stderr, "failed to write entry to output log %s: %s\n", outdir, err) |
There was a problem hiding this comment.
meta comment: If this fmt.Fprint(os.Stderr, ...); os.Exit(1) style becomes to repetetiv, you could try something like this here:
func spliceLogs() error {
// actual work with "normal" error handling
// ...
}
func main() {
// flags stuff
flag.Parse()
err:= sliceLogs()
if err!=nil {
fmt.Fprintf(os.Stderr, ... )
os.Exit(1)
}
}There was a problem hiding this comment.
ahh nice, so extract all the stuff i am doing in main to an encapsulating routine (e.g. spliceLogs)? that's a really good point, i was actually thinking that things were getting repetitive
There was a problem hiding this comment.
yes. And since this is a single-use CLI tool, you even get away with globals for the flag variables.
(In contrast to an rpc like thing where these request params would need to be passed as function arguments)
No description provided.