Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

error loading sodium bindings: libsodium.so.23 #1045

Closed
ahdinosaur opened this issue May 20, 2019 · 7 comments
Closed

error loading sodium bindings: libsodium.so.23 #1045

ahdinosaur opened this issue May 20, 2019 · 7 comments

Comments

@ahdinosaur
Copy link
Contributor

ahdinosaur commented May 20, 2019

when running latest beta.2, i get the following warning in the console:

error loading sodium bindings: libsodium.so.23: cannot open shared object file: No such file or directory
falling back to javascript version.

after doing a build locally and looking at dist/linux-unpacked/, i don't see any libsodium.so.23.

i'll see if i can fix this, as i encountered this while working on #983, but turns out it affects the AppImage as well.

@ahdinosaur ahdinosaur self-assigned this May 20, 2019
ahdinosaur added a commit that referenced this issue May 20, 2019
fixes #1045 and (theoretically) reduces build size

- sodium-native is the only dependency using prebuilds
- the only node binding we need is `electron-69.node`
  - where `$(electron --abi) == 69`
- we also need the `libsodium.so.23` shared library
  - but we must copy this into the root directory of the build (outside the compiled binary file)
@christianbundy
Copy link
Contributor

Any chance this was resolved by #1040?

@ahdinosaur
Copy link
Contributor Author

given my understanding, i don't think it would be, but i can check later.

do you not see the same error message?

@christianbundy
Copy link
Contributor

No, I'm on Arch Linux and I've got something funky going on where AppImages work for me even though they throw errors on Ubuntu machines (both Mix and Piet had the same errors). The story so far:

  • Originally we didn't have any glob to ignore prebuilds and so the binaries were huge.
  • Matt sent me a PM pointing out that the binary size had increased and pointed to the code that would minimize it.
  • I added a super-terse version of the code that somehow removed all prebuilds, not just the ones I selected.
  • Somehow this didn't cause problems for me but Mix noticed it while building Patchbay and Piet could confirm the issue.
  • The solution seemed to be removing the files key with the ignore-list glob, which was merged as Remove electron-builder rules breaking AppImages #1040.

I'd love to get rid of irrelevant prebuilds, but I want to make super sure it's not just working on my machine and breaking on Ubuntu.

ahdinosaur added a commit that referenced this issue May 21, 2019
fixes #1045 and (theoretically) reduces build size

- sodium-native is the only dependency using prebuilds
- the only node binding we need is `electron-69.node`
  - where `$(electron --abi) == 69`
- we also need the `libsodium.so.23` shared library
  - but we must copy this into the root directory of the build (outside the compiled binary file)
@christianbundy
Copy link
Contributor

Btw, if you get a chance I'm super curious to know whether this is fixed in master now. I'd love to get the build smaller, but currently my focus is just making sure the builds aren't broken on anyone's system.

I really appreciate the tinkering you're doing with getting the build smaller, just know that if there are problems it's not you, and even though the docs seem authoritative I'm about 90% sure there's a bug in electron-builder that's borking the files glob.

@christianbundy
Copy link
Contributor

Just tested Ubuntu and it looks like this is working again. Woo! I'm going to remove the "blocking release" tag, is this good to close now?

@ahdinosaur
Copy link
Contributor Author

yes, this does work on the latest release! so i'll close this, but leave #1046 open (maybe rename) to focus on how we minimize the builds. and agree, "works on my machine" is not enough for a release, glad you were able to find something that works to release 😺

@christianbundy
Copy link
Contributor

Woo! Happy this works, I'm excited to see the future of #1046. ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants