Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only let Datahub Support remove workspace leads from workspaces #1486

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

gcnabeel
Copy link
Contributor

Pull Request

Description

In the workspace user management screen, only datahub support should be allowed to remove workspace leads,

Related Issues

9660 - Only let Datahub Support remove workspace leads

Changes

added a method to determine access level in the users table

Checklist

  • [✔️ ] Code follows dotnet coding standards
  • Tests added/updated to cover changes

@gcnabeel
Copy link
Contributor Author

This PR only addresses the functionality behind who can and cannot remove workspace leads. A couple of things to consider, based on the bug report:

  1. When a user has lost the workspace lead privilege, it should be taken into effect right away -> this needs to be tested (probably in another task/PR)
  2. Can a Datahub Support remove all workspace leads? Currently, yes. In the bug report, it stated that the page crashed when all workspace leads were removed, but I was not able to reproduce that

@ErikApption ErikApption merged commit 3c7dbcf into develop Nov 29, 2024
22 checks passed
@ErikApption ErikApption deleted the nb/workspaceleadfix branch November 29, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants