💻 Re-adding the personal sidebar to many pages #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-Stilwell
requested review from
ErikApption,
davidreneuw and
gcnabeel
as code owners
|
I think it is a good first pass but to make it useful in terms of UX, we probably should rethink the content. I can't imagine that the user links are common. Should we commit to figure out a better sidebar content before next release? Otherwise wondering if this is a candidate for feature branch. I don't mind approving this version for merging but I am not sure it is good candidate for prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Following our discussion on navigation in FSDH, where broad consensus was around making both changes, this PR re-introduces the personal sidebar to make workspace navigation easy from any page.
Related Issues
Changes
Testing
Checklist