🐛 Parametrize budget rollover into a configuration #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidreneuw
requested review from
ErikApption,
Sean-Stilwell and
gcnabeel
as code owners
ErikApption
approved these changes
Feb 19, 2025
ErikApption
added a commit
that referenced
this pull request
Feb 24, 2025
* Verify that user in tenant (#1563) Co-authored-by: davidreneuw <[email protected]> * ✨ New home page (#1556) * Mock home page and drop down in sidebar * Home page mocks * New type of card * New home page * Improve workspace sidebar dropdown * Adding localization and sorting * Only show non-deleted workspaces in dropdown * Make cost bar horizontal, add label on top * Remove debug leftover --------- Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> Co-authored-by: Erik <[email protected]> * Handle missing credits better (#1570) * 💰 Updating the GC Hosting endpoint fields (#1568) * Adding migration to change what GC Hosting gives us * Updating controller to handle new fields * Updating tool page to handle new fields * Updating tool page to add the workspace budget (missed before --------- Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> * Postgres Tier code refactor (#1564) * Postgres tiers merging * code cleanup * Restricting usage emails to admins and workspace leads (#1565) * Fixing styling issue with HomeNav (#1559) * 🐛 Parametrize budget rollover into a configuration (#1562) * Parametrize budget rollover into a configuration * Fix logic to give the force option the highest authority * Adjust for unit tests --------- Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> * Adding migration for new fields (#1573) * Added unit tests for GC Hosting API (#1571) * - misc validation for hosting service controller - removed WorkspaceIdentifier since acronym is returned * added request id * added feature for gc hosting * Add files via upload * moved test files * fixed workspace storage tests * added sample requests and unit tests for hosting services api * added valid sample for latest format * fix for unit tests * fixed required values in json --------- Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> --------- Co-authored-by: davidreneuw <[email protected]> Co-authored-by: David René <[email protected]> Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> Co-authored-by: Sean Stilwell <[email protected]> Co-authored-by: gcnabeel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
A long long time ago, we had implemented a system (called "Rollover") that upon a new fiscal year, would reduce a workspace's budget by the amount they used in the prior fiscal year. E.g. DW1 used $60 out of $100 budget during fiscal year 2024-2025, on
April 1st 2025, it's budget would be lowered to $40. This was to match the Azure budgets, since they have their spending reset yearly on April 1st, so in the same example, in Azure, DW1's spending would be $0 and its budget would be $40 on April 1st 2025, effectively "rolling over" the leftover credits into the new year.
This system was made based on old assumptions, and we don't exactly make good use of Azure budgets anymore. In addition, I did not want this to happen unexpectedly, so I decided to make that behaviour a configuration, which is off by default. We can re-enable it if we want to keep it
Related Issues
Changes
Testing
Checklist