Statistics admin page #1567
Open
Statistics admin page #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shudsky
requested review from
ErikApption,
Sean-Stilwell,
davidreneuw and
gcnabeel
as code owners
There was a problem hiding this comment.
Awesome work with this Siovan. I've left a couple comments in the code itself.
Just a couple extra points:
- Is the CSV supposed to download the entire list or the filtered list? Currently it's doing everything, I just wanted to confirm this is intended.
- It looks like localization still needs to be done.
| Placeholder=@Localizer["Search by workspace name or acronym"] | ||
| Adornment="Adornment.Start" | ||
| AdornmentIcon="@Icons.Material.Filled.Search" | ||
| IconSize="Size.Medium" Class="mt-0" |
There was a problem hiding this comment.
Just to put everything in line together
Suggested change
| IconSize="Size.Medium" Class="mt-0" | |
| IconSize="Size.Medium" Class="mt-4" |
| await using var context = await _dbContextFactory.CreateDbContextAsync(); | ||
| const int numberOfDays = 7; | ||
|
|
||
|
|
||
|
|
||
|
|
||
| _statsRows = context.Projects |
There was a problem hiding this comment.
It looks like this block isn't retrieving the Workspace Lead properly, if I download the CSV it's left blank.
| Department = p.Sector_Name, | ||
| LastLogin = p.LastLoginDate | ||
|
|
||
| // Leads = p.Users?.Where(u => u.RoleId == (int) Project_Role.RoleNames.WorkspaceLead).Select(u => u.User_Name).ToList(), |
There was a problem hiding this comment.
If the code is commented out, can we just delete it for clarity?
shudsky
commented
Feb 20, 2025
|
|
||
| } | ||
| await ReloadWorkspaceStatsTableAsync(); | ||
| } |
There was a problem hiding this comment.
Need to delete this; unnecessary (just check for string values)
shudsky
commented
Feb 20, 2025
| @@ -33,6 +41,7 @@ public class DatahubProjectStatsRow | |||
| public ResourceStatus DatabricksStatus { get; set; } | |||
|
|
|||
| public bool ShowUserDetails { get; set; } | |||
| public bool ShowBudgetDetails { get; set; } | |||
There was a problem hiding this comment.
delete (check for others)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Improved admin statistics page.
Changes
Testing
Checklist