Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Steward updates #1575

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Data Steward updates #1575

wants to merge 12 commits into from

Conversation

akhavich
Copy link
Contributor

@akhavich akhavich commented Feb 21, 2025

Pull Request

Description

This PR updates a some functionality around the Data Steward attribute. It restricts the Data Steward to workspace users with the Collaborator, Admin or Workspace Lead roles, and automatically assigns Data Steward to the workspace lead whenever a new workspace is created. It also adds some under-the-hood improvements on the workspace users page.

Related Issues

User Story 9742: As a workspace lead, I want to be the default data steward in my workspace
Task 9743: Make new workspace leads the default data steward
Task 9751: Only collaborators, admins and leads should be data stewards
Task 10137: Update the workspace users page under the hood and add unit tests

Changes

  • Data Steward is restricted to Collaborators, Admins, and Workspace Leads. If changing the user role, the data steward attribute will be un-set both in the UI and when saving to the database if the user role changes to a disallowed one. The data steward checkbox in the UI will also be disabled in this case.
  • When a new workspace is created, the workspace lead will automatically be assigned as data steward by default.
  • Searching/filtering the workspace user list takes effect immediately, and is implemented more efficiently under the hood
  • Greatly improved unit test coverage of the workspace user page

Testing

  • Manual testing of workspace user page, role update and data steward update
  • Updated unit tests of the workspace users page and workspace user management service

Checklist

  • Code follows dotnet coding standards
  • Tests added/updated to cover changes

@akhavich akhavich marked this pull request as ready for review February 25, 2025 20:46
@ErikApption ErikApption enabled auto-merge (squash) February 26, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants