Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR1 | Validation 6 | Duplicate UPN - unexpected result #333

Closed
MathesonSho opened this issue Dec 30, 2024 · 2 comments · Fixed by #359
Closed

GR1 | Validation 6 | Duplicate UPN - unexpected result #333

MathesonSho opened this issue Dec 30, 2024 · 2 comments · Fixed by #359
Assignees
Labels
bug Something isn't working

Comments

@MathesonSho
Copy link
Contributor

Describe the bug
If there is a duplicate UPN in one of the columns, the user should be directed to review their lists for accuracy. Current results say the department is compliant.

Azure CaC version
v2.1.4

To Reproduce
Steps to reproduce the behavior:

  1. Add the“UserAccountsPrivilegedAndRegularUPN.csv ” fill in both columns correctly for "regular_account_UPN" and "HP_admin_account_UPN"
  2. Add a duplicate of the same upn in the "HP_admin_account_UPN"
  3. Run main runbook
  4. See error in workbook

Expected behavior
Non-compliant with a message asking to look for duplicates/ or other errors in their lists.

Screenshots
image

@MathesonSho MathesonSho added the bug Something isn't working label Dec 30, 2024
@dutt0 dutt0 self-assigned this Jan 6, 2025
@dutt0
Copy link
Contributor

dutt0 commented Jan 6, 2025

Team decision: "HP_admin_account_UPN" <- one to one relationship -> "regular_account_UPN"

@dutt0 dutt0 added the PriorityForAssignees -High This issue is considered high priority for the assignee this week label Jan 8, 2025
@MathesonSho
Copy link
Contributor Author

En:
dupHPaccount = Non-compliant. Review the highly privileged account User Principal Names (UPNs) provided for any duplicates. Remove any UPNs that are repeated.

dupRegAccount = Non-compliant. Review the regular account User Principal Names (UPNs) provided for any duplicates. Remove any UPNs that are repeated.
Fr:
dupHPaccount = Non conforme. Examinez les noms d’utilisateur principaux [User Principal Names (UPNs)] de compte à privilèges élevés fournis pour tout doublon. Supprimez tous les UPN, qui sont répétés.

dupRegAccount = Non conforme. Examinez les noms d’utilisateur principaux [User Principal Names (UPNs)] de compte réguliers fournis pour tout doublon. Supprimez tous les UPN, qui sont répétés.

@dutt0 dutt0 linked a pull request Jan 10, 2025 that will close this issue
6 tasks
@dutt0 dutt0 removed the PriorityForAssignees -High This issue is considered high priority for the assignee this week label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants