Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] GR1 V6 Handling duplicate UPN #359

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

dutt0
Copy link
Contributor

@dutt0 dutt0 commented Jan 9, 2025

Overview/Summary

This Pull Request fixes the issue when there is a duplicate UPN in one of the columns, the user should be directed to review their lists for accuracy instead of going through other conditions for compliance check.

This PR fixes/adds/changes/removes

This PR adds fix for compliant result if

  1. duplicate UPN found in highly privileged account list
  2. duplicate UPN found in regular account list
  3. File doesn't have proper header

Breaking Changes

N/A

Testing Evidence

image

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@dutt0 dutt0 changed the title Idutta/gr1 v6 use case duplicate upn [Bugfix] GR1 V6 Handling duplicate UPN Jan 10, 2025
@dutt0 dutt0 linked an issue Jan 10, 2025 that may be closed by this pull request
@dutt0 dutt0 marked this pull request as ready for review January 10, 2025 14:26
@dutt0 dutt0 merged commit 7e3d1ce into main Jan 10, 2025
6 checks passed
@dutt0 dutt0 deleted the idutta/GR1V6_use_case_duplicate_upn branch January 10, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GR1 | Validation 6 | Duplicate UPN - unexpected result
2 participants