Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] GR8 V1 Update control for Network diagram and high level design doc #213

Merged
merged 12 commits into from
Sep 19, 2024
Merged

[Enhancement] GR8 V1 Update control for Network diagram and high level design doc #213

merged 12 commits into from
Sep 19, 2024

Conversation

dutt0
Copy link
Contributor

@dutt0 dutt0 commented Sep 18, 2024 •
edited
Loading

Overview/Summary

GR8 V1 Update control for Network diagram and high level design doc

This PR fixes/adds/changes/removes

This PR is to update control for Network diagram and high level design doc for GR8 V1

Breaking Changes

N/A

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@dutt0 dutt0 linked an issue Sep 19, 2024 that may be closed by this pull request
GR8 V1 Combine both ItemNames to a single control #214
Closed
@dutt0 dutt0 removed a link to an issue Sep 19, 2024
GR8 V1 Combine both ItemNames to a single control #214
Closed
@dutt0 dutt0 linked an issue Sep 19, 2024 that may be closed by this pull request
GR8 | Validation 1: Network Architecture Diagram and High Level Design Documentation (M) #199
Closed
@dutt0 dutt0 requested a review from singhgss September 19, 2024 18:14
alalvi00
alalvi00 requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@alalvi00 alalvi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra line from the sign-scripts-development.yml and delete the commented out code

.github/workflows/sign-scripts-development.yml Outdated Show resolved Hide resolved
src/Guardrails-Common/GR-Common.psm1 Show resolved Hide resolved
@dutt0 dutt0 requested a review from alalvi00 September 19, 2024 18:57
@dutt0 dutt0 merged commit 585649b into main Sep 19, 2024
4 checks passed
@dutt0 dutt0 deleted the idutta/GR8V1_design_doc branch September 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalvi00 alalvi00 alalvi00 approved these changes

@singhgss singhgss singhgss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GR8 | Validation 1: Network Architecture Diagram and High Level Design Documentation (M)
3 participants
@dutt0 @alalvi00 @singhgss