Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] - GR7 | V3 Incorrect messaging when Application Gateway but no SSL Certificates in a listener #305

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

singhgss
Copy link
Contributor

@singhgss singhgss commented Dec 10, 2024

Overview/Summary

This Pull Request corrects the messaging displayed when an Application Gateway is present without any SSL certificates bound to its listeners. Previously, the workbooks would display an incorrect or unclear message, implying that the CA file had been processed but not indicating the absence of SSL listeners properly. This fix ensures that the message accurately reflects the scenario.

This PR fixes/adds/changes/removes

fixes #301

  1. Fixes the incorrect messaging logic so that if there are no SSL certificates in any listener, a clear message is displayed.
  2. Improves the certificate validation logic to perform a bidirectional check:
    • Validates if the certificate issuer is in or matches part of the Approved CA List.
    • Checks if the Approved CA is part of the issuer.

Breaking Changes

  • None. The fix only changes the displayed messages and does not introduce breaking changes to logic or data structures.

Testing Evidence

  • Verified by creating an Application Gateway without any SSL certificates in its listeners and checking the workbook messages. The resulting output now correctly indicates that CA file(s) were processed, but no SSL listeners were found.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensured PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script).

@singhgss singhgss changed the title Gsingh/fix incorrect messaging sslcert appgateway [BugFix] - GR7 | V3 Incorrect messaging when Application Gateway but no SSL Certificates in a listener Dec 10, 2024
@singhgss singhgss merged commit 9339fa1 into main Dec 11, 2024
4 checks passed
@singhgss singhgss deleted the gsingh/fix-incorrect-messaging-sslcert-appgateway branch December 11, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants