Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX]- Central Reporting Erroring Out Fix and GR13 addition to aggregation #358

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

singhgss
Copy link
Contributor

@singhgss singhgss commented Jan 8, 2025

This PR fixes/adds/changes/removes

fixes #346 #350

  1. Adds aggregation for GR13 in the ingestion script.
  2. Implements a fix using column_ifexists to prevent missing column errors in Central Reporting.
  3. Ensures backward compatibility for customers using older CaC versions.
  4. Added additional check so queries are not executed against central reporting tenant itself.

Breaking Changes

None. This update ensures compatibility with both older and newer CaC versions.

Testing Evidence

  1. Successfully tested ingestion script with v2.x.x and verified GR13 aggregation.
  2. Verified that using column_ifexists prevents errors in older CaC versions.
  3. Conducted end-to-end testing to ensure CentralView aggregation does not break on missing fields.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensured PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@singhgss singhgss changed the title [BUGFIX] Central Reporting Erroring Out Fix and GR13 addition to aggregation [BUGFIX]- Central Reporting Erroring Out Fix and GR13 addition to aggregation Jan 8, 2025
@dutt0 dutt0 linked an issue Jan 9, 2025 that may be closed by this pull request
@singhgss singhgss merged commit e761a48 into main Jan 9, 2025
4 checks passed
@singhgss singhgss deleted the gsingh/fix-compliance-reporting branch January 9, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants