Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] GR1 | Validation 5 | Comment for Action Group Missing on BreakGlass Account Alert Bug #372

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

alalvi00
Copy link
Contributor

@alalvi00 alalvi00 commented Jan 22, 2025

Overview/Summary

Updated the code logic to make sure the action groups are properly checked for each alert rule and that the correct message is displayed

Closes #329

This PR fixes/adds/changes/removes

  1. Check-AlertsMonitor.psm1 and Check-AlertsMonitor.psd1 files are updated
  2. Updated zip module

Breaking Changes

No breaking changes were made

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@alalvi00 alalvi00 requested a review from dutt0 January 23, 2025 14:25
@alalvi00 alalvi00 merged commit dcc7aa7 into main Jan 23, 2025
4 checks passed
@alalvi00 alalvi00 deleted the gr1v5-bugfix-aalvi branch January 23, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GR1 | Validation 5 | Comment for Action Group Missing on BreakGlass Account Alert Bug
3 participants