Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Update code for Get-AzSecurityContact error - introduced due to PS module bug #98

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

dutt0
Copy link
Contributor

@dutt0 dutt0 commented Feb 9, 2024

Overview/Summary

The command Get-AzSecurityContact gives a 'unable to deserialize the response' error. This error is only noticeable for Az.Security version 1.5.1 with runtime PS v5.1. This pull request has updated code to have a workaround for this Az.Security module bug.

This PR fixes/adds/changes/removes

This pull request has the fix using management security API

Additional context

A combination of Az.security version v1.3.0/ v1.4.0 and PS v5.1 works as expected with no error in runbook.
Az.security version v1.5.0 and PS v5.1 combination was not tested.

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@dutt0 dutt0 linked an issue Feb 9, 2024 that may be closed by this pull request
@dutt0 dutt0 changed the title [Bug fix] Updating code for runbook Get-AzSecurityContact error introduced for PS module bug [Bug fix] Update code for Get-AzSecurityContact error - introduced due to PS module bug Feb 10, 2024
@dutt0 dutt0 merged commit d4b0665 into main Feb 12, 2024
4 checks passed
@dutt0 dutt0 deleted the idutta/fix_runbook_az_security_error branch February 12, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Get-AzSecurityContact while running main runbook
3 participants