Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate Interval with @Embeddable #370

Closed
odrotbohm opened this issue Nov 23, 2021 · 2 comments
Closed

Annotate Interval with @Embeddable #370

odrotbohm opened this issue Nov 23, 2021 · 2 comments
Assignees
@vrckr
Labels
in: documentation Reference documentation, Javadoc, website meta: contribution welcome Issues ideal for people new to the project module: core Core / Time / Quantity / Payment type: enhancement Improvements and new features
Milestone
9.0

Comments

@odrotbohm
Copy link
Member

Just to make more obvious that the type can be persisted out of the box.
@odrotbohm odrotbohm added type: enhancement Improvements and new features in: documentation Reference documentation, Javadoc, website meta: contribution welcome Issues ideal for people new to the project module: core Core / Time / Quantity / Payment labels Nov 23, 2021
@odrotbohm odrotbohm mentioned this issue Sep 14, 2022
Closed
@odrotbohm
Copy link
Member Author

odrotbohm commented Dec 1, 2022 •
edited
Loading

Steps to complete:

  • Annotate Interval with @Embeddable.
  • Add property of type Interval to DummyEntity
  • Tweak IntervalIntegrationTests.SomeEntity, to not explicitly use @Embedded. Test case should still work without it.

@odrotbohm
Copy link
Member Author

It looks like fundamental support for this has already been implemented with #152.

@martinmo martinmo added this to the 9.0 milestone Dec 13, 2022
@vrckr vrckr self-assigned this Jan 22, 2023
vrckr added a commit that referenced this issue Feb 9, 2023
@vrckr
#370 Annote interval
54669a5 
Execute steps mentioned in issue #370 by annotating Interval with Embeddable, adding an Interval property to the DummyEntity and Removing the explicit Embedded annotation from the IntervalIntegrationTests.SomeEntity
vrckr added a commit that referenced this issue Feb 14, 2023
@vrckr
#370 Annote interval
50b3010 
Execute steps mentioned in issue #370 by annotating Interval with Embeddable, adding an Interval property to the DummyEntity and Removing the explicit Embedded annotation from the IntervalIntegrationTests.SomeEntity
@vrckr vrckr mentioned this issue Feb 14, 2023
Closed
odrotbohm pushed a commit that referenced this issue Feb 17, 2023
@vrckr @odrotbohm
#370 - Interval can now be used as embeddable without explicit proper…
dd0375d 
…ty annotation.

Interval is now annotated with @embeddable, so that client code doesn't have to explicitly declare a property of that type with @embeddable itself.
odrotbohm added a commit that referenced this issue Feb 17, 2023
@odrotbohm
#370 - Polishing.
e9c2fe5 
Javadoc formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrckr vrckr

Labels
in: documentation Reference documentation, Javadoc, website meta: contribution welcome Issues ideal for people new to the project module: core Core / Time / Quantity / Payment type: enhancement Improvements and new features
Projects
None yet
Milestone
9.0
Development

No branches or pull requests
3 participants
@odrotbohm @martinmo @vrckr