Code Cleanup (#56)

* code cleanup

* remove Directory.Build.props

docs/SandCastleDocuments.xml

@@ -4451,7 +4451,7 @@
         </member>
         <member name="T:Flickr.Net.Core.Entities.PlaceInfo">
             <summary>
-            Detailed information about a place. Returned by <see cref="!:IFlickrPlaces.GetInfoAsync(string, string, CancellationToken)"/>.
+            Detailed information about a place. Returned by <see cref="M:Flickr.Net.Core.IFlickrPlaces.GetInfoAsync(Flickr.Net.Core.Entities.PlaceId,System.Threading.CancellationToken)"/> or <see cref="M:Flickr.Net.Core.IFlickrPlaces.GetInfoAsync(Flickr.Net.Core.Entities.WoeId,System.Threading.CancellationToken)"/>.
             </summary>
         </member>
         <member name="P:Flickr.Net.Core.Entities.PlaceInfo.PlaceId">
@@ -4720,7 +4720,8 @@
         </member>
         <member name="T:Flickr.Net.Core.Entities.ShapeData">
             <summary>
-            The shape data supplied by <see cref="!:IFlickrPlaces.GetInfoAsync(string, string, CancellationToken)"/>.
+            The shape data supplied by <see cref="M:Flickr.Net.Core.IFlickrPlaces.GetInfoAsync(Flickr.Net.Core.Entities.PlaceId,System.Threading.CancellationToken)"/>
+            or <see cref="M:Flickr.Net.Core.IFlickrPlaces.GetInfoAsync(Flickr.Net.Core.Entities.WoeId,System.Threading.CancellationToken)"/>.
             </summary>
             <remarks>
             See <a

src/.editorconfig

@@ -0,0 +1,157 @@
+# EditorConfig is awesome:http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# Don't use tabs for indentation.
+[*]
+indent_style = space
+dotnet_style_operator_placement_when_wrapping = beginning_of_line
+tab_width = 4
+indent_size = 4
+end_of_line = crlf
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
+dotnet_style_prefer_auto_properties = true:silent
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = true:silent
+dotnet_style_prefer_conditional_expression_over_return = true:silent
+dotnet_style_explicit_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_compound_assignment = true:suggestion
+dotnet_style_prefer_simplified_interpolation = true:suggestion
+dotnet_style_namespace_match_folder = true:suggestion
+# (Please don't specify an indent_size here; that has too many unintended consequences.)
+
+# Code files
+[*.{cs,csx}]
+indent_size = 4
+
+# Xml project files
+[*.{csproj}]
+indent_size = 2
+
+# Xml config files
+[*.{props,targets,ruleset,config,nuspec,resx,vsixmanifest,vsct}]
+indent_size = 2
+
+# JSON files
+[*.json]
+indent_size = 2
+
+# proto
+[*.proto]
+indent_size = 2
+
+# Dotnet code style settings:
+[*.{cs}]
+# Sort using and Import directives with System.* appearing first
+dotnet_sort_system_directives_first = true
+# Avoid "this." and "Me." if not necessary
+dotnet_style_qualification_for_field = false:suggestion
+dotnet_style_qualification_for_property = false:suggestion
+dotnet_style_qualification_for_method = false:suggestion
+dotnet_style_qualification_for_event = false:suggestion
+
+# Use language keywords instead of framework type names for type references
+dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
+dotnet_style_predefined_type_for_member_access = true:suggestion
+
+# Suggest more modern language features when available
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_explicit_tuple_names = true:suggestion
+
+# CSharp code style settings:
+[*.cs]
+# Prefer "var" everywhere
+csharp_style_var_for_built_in_types = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+csharp_style_var_elsewhere = true:suggestion
+
+# Prefer method-like constructs to have a block body
+csharp_style_expression_bodied_methods = false:none
+csharp_style_expression_bodied_constructors = false:none
+csharp_style_expression_bodied_operators = false:none
+
+# Prefer property-like constructs to have an expression-body
+csharp_style_expression_bodied_properties = true:none
+csharp_style_expression_bodied_indexers = true:none
+csharp_style_expression_bodied_accessors = true:none
+
+# Suggest more modern language features when available
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+csharp_style_throw_expression = true:suggestion
+csharp_style_conditional_delegate_call = true:suggestion
+
+# Newline settings
+csharp_new_line_before_open_brace = all
+csharp_new_line_before_else = true
+csharp_new_line_before_catch = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_indent_labels = one_less_than_current
+csharp_using_directive_placement = outside_namespace:silent
+csharp_prefer_simple_using_statement = true:suggestion
+csharp_prefer_braces = true:silent
+csharp_style_namespace_declarations = file_scoped:suggestion
+csharp_style_prefer_method_group_conversion = true:silent
+csharp_style_prefer_top_level_statements = true:silent
+csharp_style_expression_bodied_lambdas = true:silent
+csharp_style_expression_bodied_local_functions = false:silent
+[*.{cs,vb}]
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols = types
+dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.interface.required_modifiers = 
+
+dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
+dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.types.required_modifiers = 
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix = 
+dotnet_naming_style.begins_with_i.word_separator = 
+dotnet_naming_style.begins_with_i.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case

src/Flickr.Net.Core/Entities/Collections/GalleryCollection.cs

@@ -26,7 +26,8 @@ public sealed class GalleryCollection : Collection<Gallery>, IFlickrParsable
     public int Total { get; set; }
 
     /// <summary>
-    /// The owner of these galleries if called from <see cref="IFlickrGalleries.GetListAsync(string, int, int, CancellationToken)"/>.
+    /// The owner of these galleries if called from <see cref="IFlickrGalleries.GetListAsync(string,
+    /// int, int, CancellationToken)"/>.
     /// </summary>
     public string UserId { get; set; }
 

src/Flickr.Net.Core/Entities/Collections/GalleryPhotoCollection.cs

@@ -1,7 +1,8 @@
 namespace Flickr.Net.Core.Entities.Collections;
 
 /// <summary>
-/// A list of gallery photos as returned by <see cref="IFlickrGalleries.GetPhotosAsync(string, PhotoSearchExtras, CancellationToken)"/>
+/// A list of gallery photos as returned by <see cref="IFlickrGalleries.GetPhotosAsync(string,
+/// PhotoSearchExtras, CancellationToken)"/>
 /// </summary>
 public sealed class GalleryPhotoCollection : System.Collections.ObjectModel.Collection<GalleryPhoto>, IFlickrParsable
 {

src/Flickr.Net.Core/Entities/Collections/GroupSearchResultCollection.cs

@@ -72,4 +72,3 @@ void IFlickrParsable.Load(XmlReader reader)
         reader.Skip();
     }
 }
-

src/Flickr.Net.Core/Entities/Collections/MemberCollection.cs

@@ -1,7 +1,8 @@
 namespace Flickr.Net.Core.Entities.Collections;
 
 /// <summary>
-/// A collection of members returned by the <see cref="IFlickrGroupsMembers.GetListAsync(string, MemberTypes, int, int, CancellationToken)"/> method.
+/// A collection of members returned by the <see cref="IFlickrGroupsMembers.GetListAsync(string,
+/// MemberTypes, int, int, CancellationToken)"/> method.
 /// </summary>
 public sealed class MemberCollection : System.Collections.ObjectModel.Collection<Member>, IFlickrParsable
 {

src/Flickr.Net.Core/Entities/Collections/MethodCollection.cs

@@ -17,6 +17,3 @@ void IFlickrParsable.Load(XmlReader reader)
         reader.Skip();
     }
 }
-
-
-

src/Flickr.Net.Core/Entities/Collections/PandaPhotoCollection.cs

@@ -1,7 +1,8 @@
 namespace Flickr.Net.Core.Entities.Collections;
 
 /// <summary>
-/// A collection of photos returned by the <see cref="IFlickrPanda.GetPhotosAsync(string, PhotoSearchExtras, int, int, CancellationToken)"/> methods.
+/// A collection of photos returned by the <see cref="IFlickrPanda.GetPhotosAsync(string,
+/// PhotoSearchExtras, int, int, CancellationToken)"/> methods.
 /// </summary>
 public sealed class PandaPhotoCollection : System.Collections.ObjectModel.Collection<Photo>, IFlickrParsable
 {

src/Flickr.Net.Core/Entities/Collections/PeoplePhotoCollection.cs

@@ -1,17 +1,20 @@
 namespace Flickr.Net.Core.Entities.Collections;
 
 /// <summary>
-/// A collection of photos returned by the <see cref="IFlickrPanda.GetPhotosAsync(string, PhotoSearchExtras, int, int, CancellationToken)"/> methods.
+/// A collection of photos returned by the <see cref="IFlickrPanda.GetPhotosAsync(string,
+/// PhotoSearchExtras, int, int, CancellationToken)"/> methods.
 /// </summary>
 public sealed class PeoplePhotoCollection : System.Collections.ObjectModel.Collection<Photo>, IFlickrParsable
 {
     /// <summary>
-    /// Only populate for authenticated calls to <see cref="IFlickrPeople.GetPhotosOfAsync(string, PhotoSearchExtras, int, int, CancellationToken)"/>
+    /// Only populate for authenticated calls to <see cref="IFlickrPeople.GetPhotosOfAsync(string,
+    /// PhotoSearchExtras, int, int, CancellationToken)"/>
     /// </summary>
     public int Pages { get; set; }
 
     /// <summary>
-    /// Only populate for authenticated calls to <see cref="IFlickrPeople.GetPhotosOfAsync(string, PhotoSearchExtras, int, int, CancellationToken)"/>
+    /// Only populate for authenticated calls to <see cref="IFlickrPeople.GetPhotosOfAsync(string,
+    /// PhotoSearchExtras, int, int, CancellationToken)"/>
     /// </summary>
     public int Total { get; set; }
 

src/Flickr.Net.Core/Entities/Collections/PhotoCountCollection.cs

@@ -25,4 +25,3 @@ void IFlickrParsable.Load(System.Xml.XmlReader reader)
         reader.Skip();
     }
 }
-

src/Flickr.Net.Core/Entities/Collections/PopularPhotoCollection.cs

@@ -1,7 +1,8 @@
 namespace Flickr.Net.Core.Entities.Collections;
 
 /// <summary>
-/// A list of popular photos as returned by <see cref="IFlickrStats.GetPopularPhotosAsync(DateTime, PopularitySort, int, int, CancellationToken)"/>
+/// A list of popular photos as returned by <see cref="IFlickrStats.GetPopularPhotosAsync(DateTime,
+/// PopularitySort, int, int, CancellationToken)"/>
 /// </summary>
 public sealed class PopularPhotoCollection : System.Collections.ObjectModel.Collection<PopularPhoto>, IFlickrParsable
 {

src/Flickr.Net.Core/Entities/Collections/SuggestionCollection.cs

@@ -1,7 +1,8 @@
 namespace Flickr.Net.Core.Entities.Collections;
 
 /// <summary>
-/// The collection of location suggestions returned by <see cref="IFlickrPhotosSuggestions.GetListAsync(string, SuggestionStatus, CancellationToken)"/>.
+/// The collection of location suggestions returned by <see
+/// cref="IFlickrPhotosSuggestions.GetListAsync(string, SuggestionStatus, CancellationToken)"/>.
 /// </summary>
 public sealed class SuggestionCollection : Collection<Suggestion>, IFlickrParsable
 {

src/Flickr.Net.Core/Entities/Context.cs

@@ -1,8 +1,10 @@
 namespace Flickr.Net.Core.Entities;
 
 /// <summary>
-/// The context of the current photo, as returned by <see cref="IFlickrPhotos.GetContextAsync(string, CancellationToken)"/>, <see
-/// cref="IFlickrPhotosets.GetContextAsync(string, string, CancellationToken)"/> and <see cref="IFlickrGroupsPools.GetContextAsync(string, string, CancellationToken)"/> methods.
+/// The context of the current photo, as returned by <see
+/// cref="IFlickrPhotos.GetContextAsync(string, CancellationToken)"/>, <see
+/// cref="IFlickrPhotosets.GetContextAsync(string, string, CancellationToken)"/> and <see
+/// cref="IFlickrGroupsPools.GetContextAsync(string, string, CancellationToken)"/> methods.
 /// </summary>
 public sealed class Context : IFlickrParsable
 {

src/Flickr.Net.Core/Entities/GalleryPhoto.cs

@@ -1,7 +1,8 @@
 namespace Flickr.Net.Core.Entities;
 
 /// <summary>
-/// An instance of a photo returned by <see cref="IFlickrGalleries.GetPhotosAsync(string, PhotoSearchExtras, CancellationToken)"/>.
+/// An instance of a photo returned by <see cref="IFlickrGalleries.GetPhotosAsync(string,
+/// PhotoSearchExtras, CancellationToken)"/>.
 /// </summary>
 public class GalleryPhoto : Photo, IFlickrParsable
 {

src/Flickr.Net.Core/Entities/Group.cs

@@ -26,6 +26,3 @@ public class Group
     [XmlAttribute("members", Form = XmlSchemaForm.Unqualified)]
     public int Members { get; set; }
 }
-
-
-

src/Flickr.Net.Core/Entities/GroupCategory.cs

@@ -98,4 +98,3 @@ void IFlickrParsable.Load(System.Xml.XmlReader reader)
         reader.Skip();
     }
 }
-

src/Flickr.Net.Core/Entities/GroupFullInfo.cs

@@ -1,13 +1,12 @@
-using System.Xml;
-
-namespace Flickr.Net.Core.Entities;
+namespace Flickr.Net.Core.Entities;
 
 /// <summary>
 /// Provides details of a particular group.
 /// </summary>
 /// <remarks>
-/// Used by the Url methods and <see cref="IFlickrGroups.GetInfoAsync(string, CancellationToken)"/> method. The reason for a <see
-/// cref="Group"/> and <see cref="GroupFullInfo"/> are due to xml serialization incompatabilities.
+/// Used by the Url methods and <see cref="IFlickrGroups.GetInfoAsync(string, CancellationToken)"/>
+/// method. The reason for a <see cref="Group"/> and <see cref="GroupFullInfo"/> are due to xml
+/// serialization incompatabilities.
 /// </remarks>
 public sealed class GroupFullInfo : IFlickrParsable
 {

src/Flickr.Net.Core/Entities/GroupInfo.cs

@@ -1,6 +1,4 @@
-using System.Xml;
-
-namespace Flickr.Net.Core.Entities;
+namespace Flickr.Net.Core.Entities;
 
 /// <summary>
 /// Information about public groups for a user.

src/Flickr.Net.Core/Entities/Interfaces/IFlickrParsable.cs

@@ -1,6 +1,4 @@
-using System.Xml;
-
-namespace Flickr.Net.Core.Entities.Interfaces;
+namespace Flickr.Net.Core.Entities.Interfaces;
 
 /// <summary>
 /// An interface that the classes that are returned by the Flickr API use to enable them to self-deserialize.

src/Flickr.Net.Core/Entities/Licenses.cs

@@ -6,8 +6,8 @@ namespace Flickr.Net.Core.Entities;
 public sealed class License : IFlickrParsable
 {
     /// <summary>
-    /// The ID of the license. Used by <see cref="IFlickrPhotos.GetInfoAsync(string, string, CancellationToken)"/> and <see
-    /// cref="IFlickrPhotos.GetInfoAsync(string, string, CancellationToken)"/>.
+    /// The ID of the license. Used by <see cref="IFlickrPhotos.GetInfoAsync(string, string,
+    /// CancellationToken)"/> and <see cref="IFlickrPhotos.GetInfoAsync(string, string, CancellationToken)"/>.
     /// </summary>
     public LicenseType LicenseId { get; set; }
 

src/Flickr.Net.Core/Entities/Place.cs

@@ -56,7 +56,10 @@ public sealed class Place : IFlickrParsable
     /// <summary>
     /// The number of photos the calling user has for this place.
     /// </summary>
-    /// <remarks>Only returned for <see cref="IFlickrPlaces.PlacesForUserAsync(PlaceType, string, string, int, DateTime?, DateTime?, DateTime?, DateTime?, CancellationToken)"/>.</remarks>
+    /// <remarks>
+    /// Only returned for <see cref="IFlickrPlaces.PlacesForUserAsync(PlaceType, string, string,
+    /// int, DateTime?, DateTime?, DateTime?, DateTime?, CancellationToken)"/>.
+    /// </remarks>
     public int? PhotoCount { get; set; }
 
     /// <summary>

src/Flickr.Net.Core/Entities/StatReferrer.cs

@@ -1,8 +1,12 @@
 namespace Flickr.Net.Core.Entities;
 
 /// <summary>
-/// The referrer details returned by <see cref="IFlickrStats.GetCollectionReferrersAsync(DateTime, string, string, int, int, CancellationToken)"/>, <see cref="IFlickrStats.GetPhotoReferrersAsync(DateTime, string, string, int, int, CancellationToken)"/>, <see cref="IFlickrStats.GetPhotosetReferrersAsync(DateTime, string, string, int, int, CancellationToken)"/> and
-/// <see cref="IFlickrStats.GetPhotostreamReferrersAsync(DateTime, string, int, int, CancellationToken)"/>.
+/// The referrer details returned by <see cref="IFlickrStats.GetCollectionReferrersAsync(DateTime,
+/// string, string, int, int, CancellationToken)"/>, <see
+/// cref="IFlickrStats.GetPhotoReferrersAsync(DateTime, string, string, int, int,
+/// CancellationToken)"/>, <see cref="IFlickrStats.GetPhotosetReferrersAsync(DateTime, string,
+/// string, int, int, CancellationToken)"/> and <see
+/// cref="IFlickrStats.GetPhotostreamReferrersAsync(DateTime, string, int, int, CancellationToken)"/>.
 /// </summary>
 public sealed class StatReferrer : IFlickrParsable
 {

src/Flickr.Net.Core/Entities/Stats.cs

@@ -1,8 +1,10 @@
 namespace Flickr.Net.Core.Entities;
 
 /// <summary>
-/// The stats returned by <see cref="IFlickrStats.GetPhotoStatsAsync(DateTime, string, CancellationToken)"/>, <see
-/// cref="IFlickrStats.GetPhotostreamStatsAsync(DateTime, CancellationToken)"/>, <see cref="IFlickrStats.GetPhotosetStatsAsync(DateTime, string, CancellationToken)"/> and <see cref="IFlickrStats.GetCollectionStatsAsync(DateTime, string, CancellationToken)"/>
+/// The stats returned by <see cref="IFlickrStats.GetPhotoStatsAsync(DateTime, string,
+/// CancellationToken)"/>, <see cref="IFlickrStats.GetPhotostreamStatsAsync(DateTime,
+/// CancellationToken)"/>, <see cref="IFlickrStats.GetPhotosetStatsAsync(DateTime, string,
+/// CancellationToken)"/> and <see cref="IFlickrStats.GetCollectionStatsAsync(DateTime, string, CancellationToken)"/>
 /// </summary>
 public sealed class Stats : IFlickrParsable
 {