Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json Support #59

Merged
merged 22 commits into from
Jul 4, 2023
Merged

Json Support #59

merged 22 commits into from
Jul 4, 2023

Conversation

st0o0
Copy link
Owner

@st0o0 st0o0 commented Jun 17, 2023

No description provided.

@st0o0 st0o0 requested a review from LineOfC0d3 June 17, 2023 08:02
@st0o0 st0o0 self-assigned this Jun 17, 2023
@st0o0 st0o0 changed the title WIP Json Support Json Support Jul 3, 2023
@st0o0 st0o0 marked this pull request as draft July 4, 2023 07:55
@st0o0 st0o0 marked this pull request as ready for review July 4, 2023 07:56
LineOfC0d3
LineOfC0d3 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@LineOfC0d3 LineOfC0d3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

There is a great degree of redundancy in the entities
i.e. the following Properties (found in many "xxPhoto" Entities)
` [JsonProperty("ispublic")]
public bool IsPublic { get; set; }

[JsonProperty("isfriend")]
public bool IsFriend { get; set; }

[JsonProperty("isfamily")]
public bool IsFamily { get; set; }`
  • This review was brought to you by 4 hours of sleep

@st0o0
Copy link
Owner Author

st0o0 commented Jul 4, 2023

@LineOfC0d3
yes what name for the entity where i can abstract the three properties would you suggest

@LineOfC0d3 LineOfC0d3 merged commit 9f0d89b into featrue/last-core-changes Jul 4, 2023
st0o0 added a commit that referenced this pull request Jul 4, 2023
@st0o0 @LineOfC0d3
Json Support (#59)
6a1aad6 
* first json objects test

* And more json tests

* update

* and more json entities

* add more more more

* code cleanup

* update

* add more json entities

* update

* Update

* update

* update

* refactor all enums

* update

* update

* ready for review

* update

* little code cleanup

* add LineOfC0d3 to code owners

* remove LineOfC0d3 from CodeOwners

* cleanup: removed todo and commented out code

---------

Co-authored-by: Dominik <[email protected]>
@st0o0 st0o0 deleted the feature/json-support branch July 5, 2023 15:39
@st0o0 st0o0 restored the feature/json-support branch July 6, 2023 03:56
@st0o0 st0o0 deleted the feature/json-support branch July 6, 2023 04:33
st0o0 added a commit that referenced this pull request Jul 8, 2023
@st0o0 @LineOfC0d3
Full revision of Entities & json support (#58)
c65ec70 
* update

update HttpRequestMessage

update

add Attribute idea

* rebase

* add LineOfC0d3 to CodeOwners

* Json Support (#59)

* first json objects test

* And more json tests

* update

* and more json entities

* add more more more

* code cleanup

* update

* add more json entities

* update

* Update

* update

* update

* refactor all enums

* update

* update

* ready for review

* update

* little code cleanup

* add LineOfC0d3 to code owners

* remove LineOfC0d3 from CodeOwners

* cleanup: removed todo and commented out code

---------

Co-authored-by: Dominik <[email protected]>

* update

* update

* update

* update

* update

* update

* update

* update

* Move new entities (#63)

KEKW

* KEKW

---------

Co-authored-by: Dominik <[email protected]>
st0o0 added a commit that referenced this pull request Nov 23, 2023
@st0o0 @renovate @LineOfC0d3
First Release (#78)
26c629b 
* Update cd.yml

* Update cd.yml (#30)

* Update cd.yml

* Update cd.yml

* add azure-pipeline

* Update dependency Microsoft.NET.Test.Sdk to v17.6.1 (#33)

* Update dependency Microsoft.NET.Test.Sdk to v17.6.1

* Update ci.yml for Azure Pipelines

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jan <[email protected]>

* Refactor all flickr entities (#34)

* refactor all flickr entities

* update

* implementation interface idea

* update

* remove all apikey

* update

* update

* update

* update

* update Flickr.cs

* add settings classes

* add doc generator idea and add xml docs

* Update Blog.cs

Fixed docs formatting

* Update Contact.cs

fixed typos in "authenticated"

* fixed misaligned comment tags

* Update Flickr.Net.Core.csproj

Changed absolute path (local) to relative path

---------

Co-authored-by: Jan Schloots <[email protected]>
Co-authored-by: Dominik <[email protected]>

* Update dependency Microsoft.NET.Test.Sdk to v17.6.2 (#35)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add docs site (#37)

add doc publish workflow

Co-authored-by: Jan Schloots <[email protected]>

* Create docfx-build-publish.yml

* Add doc folder

update

Co-authored-by: Jan Schloots <[email protected]>

* Update docfx-build-publish.yml (#42)

* Update actions/checkout action to v3

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update crazy-max/ghaction-chocolatey action to v2 (#44)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update actions/setup-dotnet action to v3

* Update crazy-max/ghaction-chocolatey action to v2 (#44)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update actions/setup-dotnet action to v3

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Create codeql.yml

* Update issue templates

* Create CODE_OF_CONDUCT.md

* fix old issues and bugs

* update

* more refactor

* update and good night

* little changes

* update

* add dev container

* update

* PlaceId and WoeId solution (#52)

* add WoeId and PlaceId structs

* refactor more

* add implicit operator

* Update release-pipeline.yml for Azure Pipelines (#53)

* Update release-pipeline.yml for Azure Pipelines (#54)

* Update release-pipeline.yml for Azure Pipelines (#55)

* Update release-pipeline.yml for Azure Pipelines

* Update release-pipeline.yml for Azure Pipelines

* Code Cleanup (#56)

* code cleanup

* remove Directory.Build.props

* Update dependency Microsoft.NET.Test.Sdk to v17.6.3 (#60)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency xunit.runner.visualstudio to v2.5.0 (#62)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency xunit to v2.5.0 (#61)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Full revision of Entities & json support (#58)

* update

update HttpRequestMessage

update

add Attribute idea

* rebase

* add LineOfC0d3 to CodeOwners

* Json Support (#59)

* first json objects test

* And more json tests

* update

* and more json entities

* add more more more

* code cleanup

* update

* add more json entities

* update

* Update

* update

* update

* refactor all enums

* update

* update

* ready for review

* update

* little code cleanup

* add LineOfC0d3 to code owners

* remove LineOfC0d3 from CodeOwners

* cleanup: removed todo and commented out code

---------

Co-authored-by: Dominik <[email protected]>

* update

* update

* update

* update

* update

* update

* update

* update

* Move new entities (#63)

KEKW

* KEKW

---------

Co-authored-by: Dominik <[email protected]>

* Add Url Extensions (#64)

* KEKW

* little changes

* last changes

* last last changes

* update Copyrights

* Update dependency Microsoft.NET.Test.Sdk to v17.7.0 (#66)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency Microsoft.NET.Test.Sdk to v17.7.1 (#67)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency Microsoft.NET.Test.Sdk to v17.7.2 (#69)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update actions/checkout action to v4 (#71)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update crazy-max/ghaction-chocolatey action to v3 (#72)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update xunit-dotnet monorepo to v2.5.1 (#73)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update xunit-dotnet monorepo (#74)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency Microsoft.NET.Test.Sdk to v17.8.0 (#76)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update xunit-dotnet monorepo (#75)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Feature/net8 remove newtonsoft (#77)

* use streaming deserialize

* code cleanup

* update

* remove unused usings

* �FlickrConvert: changed to System.Text.JSON

* fixed not working: WithAddedModifier, updated references

* FlickrConvert: getting DeclaringType using reflection

* added IdentifierConverters

* Add dotnet preview in devcontainer

* FlickrConvert: fixed properties not being assigned

* changed JsonProperty to JsonPropertyName

* updated converters

* FlickrResult: replaced JToken with JsonElement

* added CustomJsonStringEnumConverter

* removed GenericJsonPropertyNameContractResolver

* update devcontainer.json

* update devcontainer

Signed-off-by: GitHub <[email protected]>

* revert update devcontainer

Signed-off-by: GitHub <[email protected]>

* idk

* KEKW @st0o0

* Update devcontainer.json

* Update devcontainer.json

* update

* update

* it's working again 💌

* little fix and improvements

* refactor and update

* update dotnet sdk version

* fix pipeline

* update IncludePreview to false

* litte cleanup

* code cleanup

* fix naming

* update nuget dependencies

---------

Signed-off-by: GitHub <[email protected]>
Co-authored-by: Dominik <[email protected]>

---------

Signed-off-by: GitHub <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jan Schloots <[email protected]>
Co-authored-by: Dominik <[email protected]>
Co-authored-by: Dominik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LineOfC0d3 LineOfC0d3 LineOfC0d3 approved these changes

Assignees

@st0o0 st0o0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0o0 @LineOfC0d3