-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolves #4 #5
Conversation
Hi there @m-mohr |
Hi @m-mohr, looking forward for your feedback on this one :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new field is missing in the field table.
@@ -36,6 +36,7 @@ The fields in the table below can be used in these parts of STAC documents:
| product:type | string | The product type. |
| product:timeliness | string | The average expected timeliness of the product as an [ISO 8601 Duration](https://en.wikipedia.org/wiki/ISO_8601#Durations). |
| product:timeliness_category | string | A proprietary category identifier for the timeliness of the product. |
+| product:acquisition_type | string | The acquisition type of the product. |
> \[!IMPORTANT]
> `product:timeliness` is REQUIRED if `product:timeliness_category` is provided.
@emmanuelmathot looking forward for your review |
@m-mohr I addressed also all the MD warnings, build should be clean right now |
@m-mohr addressed also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@m-mohr at the state of the art, we got approvals from both @emmanuelmathot and @fabricebrito , PR can be now merged, many thanks in advance! |
Thanks @emmanuelmathot for merging, very appreciated! |
As per commit message, this modification introduces the product:acquisition_type property