Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selecting the search endpoint using media_type #142

Merged
merged 12 commits into from
Apr 19, 2022
Merged

Add support for selecting the search endpoint using media_type #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4d75059
Add support for selecting the search endpoint using `media_type`
mneagul Feb 24, 2022
87cdb77
Update pystac_client/client.py
mneagul Mar 1, 2022
2dbb015
Update pystac_client/client.py
mneagul Mar 1, 2022
c2f4172
Update pystac_client/client.py
mneagul Mar 1, 2022
8a100bc
Update pystac_client/client.py
mneagul Mar 1, 2022
d896bb4
Update CHANGELOG.md
mneagul Mar 1, 2022
b496c20
remove unused import
mneagul Mar 1, 2022
d1504ac
Update CHANGELOG.md
mneagul Apr 6, 2022
12db886
Remove unused docstring
mneagul Apr 19, 2022
3e0c923
Merge branch 'main' of github.com:sage-group/pystac-client
mneagul Apr 19, 2022
1e0ee65
Merge branch 'main' of https://github.com/stac-utils/pystac-client
mneagul Apr 19, 2022
6678ca5
Remove search endpoint `media_type` argument
mneagul Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Added

- `Client.search` accepts an optional `filter_lang` argument for `filter` requests [#128](https://github.com/stac-utils/pystac-client/pull/128)
- Added support for filtering the search endpoint using the `media_type` in `Client.open` [#142](https://github.com/stac-utils/pystac-client/pull/142)

### Fixed
- Values from `parameters` and `headers` arguments to `Client.open` and `Client.from_file` are now also used in requests made from `CollectionClient` instances
Expand Down
5 changes: 2 additions & 3 deletions pystac_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def open(
catalog : A :class:`Client` instance for this Catalog/API
"""
cat = cls.from_file(url, headers=headers, parameters=parameters)
search_link = cat.get_links('search')
search_link = cat.get_links('search', media_type=pystac.MediaType.GEOJSON)
# if there is a search link, but no conformsTo advertised, ignore conformance entirely
# NOTE: this behavior to be deprecated as implementations become conformant
if ignore_conformance or ('conformsTo' not in cat.extra_fields.keys()
Expand Down Expand Up @@ -168,8 +168,7 @@ def search(self, **kwargs: Any) -> ItemSearch:
<https://github.com/radiantearth/stac-api-spec/tree/master/item-search>`__ or does not have a link with
a ``"rel"`` type of ``"search"``.
"""

search_link = self.get_single_link('search')
search_link = self.get_single_link('search', media_type=pystac.MediaType.GEOJSON)
if search_link is None:
raise NotImplementedError(
'No link with "rel" type of "search" could be found in this catalog')
Expand Down