-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added modifier
hook to StacApiIO
to enable AWS SigV4 signing
#372
Conversation
Codecov ReportBase: 85.30% // Head: 85.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
+ Coverage 85.30% 85.35% +0.05%
==========================================
Files 11 11
Lines 796 799 +3
==========================================
+ Hits 679 682 +3
Misses 117 117
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, looks good. One question inline, and one top-level ask: could you include your example usage from #372 (comment) in the documentation? Even if we don't add software support for AWS SigV4, having a documentation example might save us some questions down the road.
7e4738e
to
43d5a38
Compare
@gadomski I added a tutorial for using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for including the documentation. The only issue is that, when I build the docs locally, the tutorial ends up with a bunch of errors due to the dummy endpoint in the docs:
Can we either:
- Use a real endpoint, or
- Do some sort of
no_run
configuration to prevent the errors from appearing when building the docs?
@gadomski I changed the authentication tutorial form a jupyter notebook to markdown. It looks like Sphinx won't execute the python in this case. That should remove the errors in the doc generation, while still keeping decent-looking formatting. |
A modifier provides the ability to modify the request immediately before sending, a requirement for AWS SigV4. This allows users to plug in their signing method. Also, added the `stac_io` parameter to `Client.open()` allowing for easy usage of a custom `StacApiIO` instance.
This includes the AWS SigV4 example.
Converted authentication tutorial to markdown, this avoids python execution.
Related Issue(s):
Description:
A modifier provides the ability to modify the request immediately before sending, a requirement for AWS SigV4. This allows users to plug in their signing method.
Also, added the
stac_io
parameter toClient.open()
allowing for easy usage of a customStacApiIO
instance.Using this PR, an application could access a private stac-server protected behind AWS IAM authentication as follows:
PR Checklist: