Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use urljoin, not string cat, for urls #746

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Use urljoin, not string cat, for urls #746

merged 2 commits into from
Oct 23, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 22, 2024 •
edited
Loading

Related Issue(s):

Description:

We were constructing urls with string concatenation, which doesn't respect query strings. This PR adds a utility function to build 'em better.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski requested a review from jsignell October 22, 2024 13:44
@gadomski gadomski self-assigned this Oct 22, 2024
@gadomski gadomski mentioned this pull request Oct 22, 2024
Closed
ircwaves
ircwaves approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@ircwaves ircwaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was in the neighborhood, despising string-fu, I approve this heartily.

@gadomski gadomski merged commit 22b09e8 into main Oct 23, 2024
15 checks passed
@gadomski gadomski deleted the issues/745-f-in-get-request branch October 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ircwaves ircwaves ircwaves approved these changes

@jsignell jsignell Awaiting requested review from jsignell

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client.get_collection() doesn't work with GeoServer OSEO STAC API
2 participants
@gadomski @ircwaves