-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Use Poetry for package management #465
Comments
I'm +1 for this change. I use poetry for other projects and really like it. I'm also in favor of starting to consolidate around a |
Tl;dr: 👎🏼 because I don't think the juice is worth the squeeze.
We've done this bit: #1100 As for the rest of @l0b0's points, some of them are addressed by #1100 (2, 3, 6). Some that aren't:
I'm not convinced a lock file is useful for a library like pystac. I'm happy to be persuaded otherwise.
Again, seems like a nice-to-have rather than a needs-to-have, and should be therefore weighed against the added complexity of adding a new build system.
I don't quite see the value in this, but I'm not a poetry user so maybe I'm missing something. |
I'm going to close this as wontfix because:
I think if we do re-open, please do so w/ a PR. |
Another suggestion based on using it in a few other projects: Poetry improves Python package management in several ways over
pip
:pyproject.toml
file, which is also supported by tools likeblack
,coverage
andmypy
, so we could actually reduce the number of configuration files.pip
.pyproject.toml
, and warns if the lockfile is out of sync with the main configuration.activate
script, for example runningpoetry run git gui&
(will run the pre-commit hooks within the virtualenv when committing inside the GUI) orpoetry run ./scripts/test
.Cons:
The text was updated successfully, but these errors were encountered: