Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml instead of setup.py #1100

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Apr 21, 2023

Related Issue(s):

Description:

While tackling #1085, I took the opportunity to migrate our setup.py configuration to pyproject.toml. As of PEP 621, pyproject.toml is the preferred way to specify project metadata, and setuptools began supporting it in version 61.0.0.

This should mostly be a noop, with the following exceptions:

  • I changed the authors from stac-utils to @lossyrob and @duckontheweb
  • I added myself as a maintainer
  • I fixed The benchmarks module is being shipped with the tarball. #1085
  • I moved our requirements-*.txt files into pyproject.toml as optional dependencies, and updated the docs accordingly
  • I changed our development requirements to prefer ~= to reduce our dependabot noise
  • I updated our development status to stable, as we're beyond v1
  • I did some minor documentation fixups
  • I changed the vanilla CI check to be named without-orjson to be more clear about what it does

No code changes. If this change works well, we should do the same for stactools and pystac-client.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.
  • (once approved) Change required CI checks from vanilla to without-orjson

@gadomski gadomski added this to the 1.8 milestone Apr 21, 2023
@gadomski gadomski requested a review from jsignell April 21, 2023 15:59
@gadomski gadomski self-assigned this Apr 21, 2023
@gadomski gadomski force-pushed the issues/1085-shipping-benchmarks branch 2 times, most recently from 8ad3fef to 563a63a Compare April 21, 2023 16:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (930a999) 90.33% compared to head (563a63a) 90.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          48       48           
  Lines        6325     6325           
  Branches      942      942           
=======================================
  Hits         5714     5714           
  Misses        429      429           
  Partials      182      182           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski force-pushed the issues/1085-shipping-benchmarks branch 2 times, most recently from 4341252 to b7dae7a Compare April 21, 2023 16:28
Includes updates to CI to work with the new setup, and doc changes to describe
how to install with the new layout.
@gadomski gadomski force-pushed the issues/1085-shipping-benchmarks branch from b7dae7a to eccd907 Compare April 21, 2023 16:29
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so nice!

MANIFEST.in Show resolved Hide resolved
@gadomski gadomski added this pull request to the merge queue Apr 21, 2023
Merged via the queue into main with commit eaa46a4 Apr 21, 2023
@gadomski gadomski deleted the issues/1085-shipping-benchmarks branch April 21, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The benchmarks module is being shipped with the tarball. Should we update development status?
3 participants