Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catalog.fully_resolve #1001

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Add Catalog.fully_resolve #1001

merged 5 commits into from
Feb 23, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 22, 2023

Related Issue(s):

Description:

Pretty simple, we just use Catalog.walk.

Sidecar fixes:

  • Tweak to the PR template to put the related items in a list by default -- this is how you need to format things to activate closing keywords
  • Make the build status badge in the README a link

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the 1.7 milestone Feb 22, 2023
@gadomski gadomski requested a review from pjhartzell February 22, 2023 16:07
@gadomski gadomski self-assigned this Feb 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (f78637a) to head (a263672).
Report is 314 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          47       47           
  Lines        6180     6184    +4     
  Branches      927      929    +2     
=======================================
+ Hits         5582     5586    +4     
  Misses        420      420           
  Partials      178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_catalog.py Outdated Show resolved Hide resolved
@gadomski gadomski mentioned this pull request Feb 23, 2023
@gadomski gadomski force-pushed the issues/478-fully-resolve branch from f20e2e2 to a263672 Compare February 23, 2023 21:40
@gadomski gadomski requested a review from pjhartzell February 23, 2023 21:40
@gadomski gadomski merged commit 8db9afb into main Feb 23, 2023
@gadomski gadomski deleted the issues/478-fully-resolve branch February 23, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'fully_resolve' back to STACObject
3 participants