Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra_fields to AssetDefinition #1003

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 22, 2023

Related Issue(s):

Description:

Pretty simple.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the 1.7 milestone Feb 22, 2023
@gadomski gadomski requested a review from pjhartzell February 22, 2023 20:48
@gadomski gadomski self-assigned this Feb 22, 2023
@gadomski gadomski added this pull request to the merge queue Feb 23, 2023
Merged via the queue into main with commit ec95277 Feb 23, 2023
@gadomski gadomski deleted the issues/855-extra-fields-item-assets branch February 23, 2023 13:32
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (ba07305) to head (66b4a1b).
Report is 318 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1003      +/-   ##
==========================================
+ Coverage   90.15%   90.32%   +0.16%     
==========================================
  Files          47       47              
  Lines        6178     6180       +2     
  Branches      926      927       +1     
==========================================
+ Hits         5570     5582      +12     
+ Misses        426      420       -6     
+ Partials      182      178       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extra_fields to extensions.item_assets.AssetDefinition
2 participants