Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When instantiating ItemCollections clone items by default #1016

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Feb 28, 2023

Related Issue(s):

Description:

NOTE this PR changes the behavior when adding item collections. After this PR adding item collections will no longer dedupe items.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski self-requested a review February 28, 2023 17:20
@gadomski gadomski added this to the 1.7 milestone Feb 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (7b704a5) 90.32% compared to head (164876f) 90.32%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
- Coverage   90.32%   90.32%   -0.01%     
==========================================
  Files          47       47              
  Lines        6184     6181       -3     
  Branches      929      927       -2     
==========================================
- Hits         5586     5583       -3     
  Misses        420      420              
  Partials      178      178              
Impacted Files Coverage Δ
pystac/item_collection.py 91.54% <100.00%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CHANGELOG entry.

pystac/item_collection.py Show resolved Hide resolved
@gadomski gadomski enabled auto-merge March 1, 2023 18:41
@gadomski gadomski added this pull request to the merge queue Mar 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 1, 2023
@gadomski gadomski added this pull request to the merge queue Mar 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 1, 2023
@gadomski gadomski enabled auto-merge March 1, 2023 19:13
@gadomski gadomski added this pull request to the merge queue Mar 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 1, 2023
@gadomski gadomski added this pull request to the merge queue Mar 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 1, 2023
@gadomski gadomski enabled auto-merge March 1, 2023 19:52
@gadomski gadomski added this pull request to the merge queue Mar 1, 2023
Merged via the queue into stac-utils:main with commit 494d92c Mar 1, 2023
@jsignell jsignell deleted the clone-items branch March 2, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ItemCollection constructor should clone items in iterator by default
3 participants