-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When instantiating ItemCollections clone items by default #1016
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01%
==========================================
Files 47 47
Lines 6184 6181 -3
Branches 929 927 -2
==========================================
- Hits 5586 5583 -3
Misses 420 420
Partials 178 178
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a CHANGELOG entry.
Related Issue(s):
Description:
NOTE this PR changes the behavior when adding item collections. After this PR adding item collections will no longer dedupe items.
PR Checklist:
pre-commit run --all-files
)scripts/test
)