Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up releasing workflow and docs #1032

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Fix up releasing workflow and docs #1032

merged 3 commits into from
Mar 9, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Mar 6, 2023

Description:

I didn't get the release flow quite right for https://github.com/stac-utils/pystac/releases/tag/v1.7.0, so this fixes up the docs for next time, and tweaks the workflow to run on publish (and not just created, since created only fires if you make a new tag).

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added the documentation Issues related to PySTAC documentation label Mar 6, 2023
@gadomski gadomski requested a review from pjhartzell March 6, 2023 21:52
@gadomski gadomski self-assigned this Mar 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (50939ee) to head (cb994c7).
Report is 274 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1032   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          47       47           
  Lines        6213     6213           
  Branches      929      929           
=======================================
  Hits         5613     5613           
  Misses        422      422           
  Partials      178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski marked this pull request as ready for review March 7, 2023 15:50
@gadomski gadomski added this pull request to the merge queue Mar 9, 2023
Merged via the queue into main with commit e920682 Mar 9, 2023
@gadomski gadomski deleted the fix-releasing-docs branch March 9, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues related to PySTAC documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants