Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate self links on items #1103

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Apr 24, 2023

Related Issue(s):

Description:

The self link is set in the constructor, so from_dict doesn't need to add the link again. This PR is against the v1.7 branch so we can use it to release a bugfix v1.7.3.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the 1.7.3 milestone Apr 24, 2023
@gadomski gadomski requested a review from pjhartzell April 24, 2023 17:26
@gadomski gadomski self-assigned this Apr 24, 2023
@gadomski gadomski changed the base branch from main to v1.7 April 24, 2023 17:26
@gadomski gadomski force-pushed the issues/1102-duplicate-self-links branch 2 times, most recently from 09a806f to 6405e45 Compare April 24, 2023 17:30
pystac/item.py Outdated Show resolved Hide resolved
@gadomski gadomski force-pushed the issues/1102-duplicate-self-links branch from 6405e45 to c2a4a97 Compare April 24, 2023 22:03
@gadomski gadomski requested a review from pjhartzell April 25, 2023 14:35
@gadomski gadomski merged commit 71f1708 into v1.7 Apr 25, 2023
@gadomski gadomski deleted the issues/1102-duplicate-self-links branch April 25, 2023 19:02
This was referenced Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate self link in pystac 1.7.2
2 participants