Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include collection assets in make_all_asset_hrefs_relative/absolute #1168

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 21, 2023

Related Issue(s):

Description:

Broadly "all_assets" for a catalog should include collection assets. Specifically I needed this functionality to solve the stactools issue

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link
Member

@ircwaves ircwaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think my suggestion is required, but it reads cleaner to my brain. As a bonus, a commit will bonk the CI when landsat's stac-api is back up and running.

pystac/collection.py Outdated Show resolved Hide resolved
@jsignell jsignell enabled auto-merge June 22, 2023 14:46
@jsignell jsignell added this pull request to the merge queue Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.11 ⚠️

Comparison is base (d88fba8) 92.06% compared to head (429b26b) 91.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   92.06%   91.96%   -0.11%     
==========================================
  Files          50       50              
  Lines        6708     6720      +12     
  Branches      990      994       +4     
==========================================
+ Hits         6176     6180       +4     
- Misses        357      365       +8     
  Partials      175      175              
Impacted Files Coverage Δ
pystac/collection.py 92.85% <44.44%> (-3.36%) ⬇️
pystac/item.py 93.98% <66.66%> (+0.73%) ⬆️
pystac/catalog.py 93.37% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Merged via the queue into stac-utils:main with commit dd999cd Jun 22, 2023
@jsignell jsignell deleted the copy-assets branch June 22, 2023 14:59
@gadomski gadomski mentioned this pull request Oct 13, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants