Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.8.0 #1176

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Release v1.8.0 #1176

merged 1 commit into from
Jun 30, 2023

Conversation

gadomski
Copy link
Member

Description:

Opening as a draft b/c I want to run the benchmark suite before merging+releasing, and that takes a hot minute.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.
  • (when approved) Close 1.8 milestone

@gadomski gadomski added this to the 1.8 milestone Jun 27, 2023
@gadomski gadomski self-assigned this Jun 27, 2023
@gadomski
Copy link
Member Author

Benchmarks look ok on my box:

$ asv compare v1.7.3 main
All benchmarks:

       before           after         ratio
     [04960115]       [5b6622c9]
     <v1.7.3^0>       <main>    
          103±7μs         98.1±3μs     0.95  catalog.CatalogBench.time_catalog_from_dict [gadomski/virtualenv-py3.11]
          103±4μs          100±4μs     0.98  catalog.CatalogBench.time_catalog_from_dict [gadomski/virtualenv-py3.11-orjson]
         271±20μs          257±7μs     0.95  catalog.CatalogBench.time_catalog_from_file [gadomski/virtualenv-py3.11]
         260±10μs          247±7μs     0.95  catalog.CatalogBench.time_catalog_from_file [gadomski/virtualenv-py3.11-orjson]
         419±50μs          391±6μs     0.93  catalog.CatalogBench.time_catalog_save [gadomski/virtualenv-py3.11]
         352±10μs         355±40μs     1.01  catalog.CatalogBench.time_catalog_save [gadomski/virtualenv-py3.11-orjson]
         177±10μs          173±5μs     0.98  catalog.CatalogBench.time_catalog_to_dict [gadomski/virtualenv-py3.11]
          176±9μs          175±5μs     1.00  catalog.CatalogBench.time_catalog_to_dict [gadomski/virtualenv-py3.11-orjson]
-        18.2±1ms       16.2±0.5ms     0.89  catalog.ReadCatalogBench.time_read_and_walk [gadomski/virtualenv-py3.11]
       15.9±0.7ms       15.9±0.9ms     0.99  catalog.ReadCatalogBench.time_read_and_walk [gadomski/virtualenv-py3.11-orjson]
            29.1M            29.4M     1.01  catalog.WalkCatalogBench.peakmem_walk [gadomski/virtualenv-py3.11]
            29.7M            30.1M     1.01  catalog.WalkCatalogBench.peakmem_walk [gadomski/virtualenv-py3.11-orjson]
         245±20μs          226±6μs     0.93  catalog.WalkCatalogBench.time_walk [gadomski/virtualenv-py3.11]
          239±8μs          226±6μs     0.94  catalog.WalkCatalogBench.time_walk [gadomski/virtualenv-py3.11-orjson]
         497±20ms          474±8ms     0.95  catalog.WriteCatalogBench.time_normalize_and_save [gadomski/virtualenv-py3.11]
         439±10ms          422±7ms     0.96  catalog.WriteCatalogBench.time_normalize_and_save [gadomski/virtualenv-py3.11-orjson]
         216±20μs          201±9μs     0.93  collection.CollectionBench.time_collection_from_dict [gadomski/virtualenv-py3.11]
          207±7μs          200±6μs     0.97  collection.CollectionBench.time_collection_from_dict [gadomski/virtualenv-py3.11-orjson]
         417±40μs         386±10μs     0.93  collection.CollectionBench.time_collection_from_file [gadomski/virtualenv-py3.11]
         384±20μs         364±10μs     0.95  collection.CollectionBench.time_collection_from_file [gadomski/virtualenv-py3.11-orjson]
         533±70μs         497±10μs     0.93  collection.CollectionBench.time_collection_save [gadomski/virtualenv-py3.11]
         380±10μs         390±40μs     1.02  collection.CollectionBench.time_collection_save [gadomski/virtualenv-py3.11-orjson]
         205±20μs          200±5μs     0.98  collection.CollectionBench.time_collection_to_dict [gadomski/virtualenv-py3.11]
          199±9μs          202±5μs     1.01  collection.CollectionBench.time_collection_to_dict [gadomski/virtualenv-py3.11-orjson]
       2.89±0.2μs      2.83±0.03μs     0.98  extensions.projection.ProjectionBench.time_add_projection_extension [gadomski/virtualenv-py3.11]
      2.81±0.06μs      2.89±0.08μs     1.03  extensions.projection.ProjectionBench.time_add_projection_extension [gadomski/virtualenv-py3.11-orjson]
         98.4±4ms         98.0±5ms     1.00  import_pystac.ImportPySTACBench.timeraw_import_pystac [gadomski/virtualenv-py3.11]
          107±2ms          111±8ms     1.05  import_pystac.ImportPySTACBench.timeraw_import_pystac [gadomski/virtualenv-py3.11-orjson]
         433±40μs         398±10μs     0.92  item.ItemBench.time_item_from_dict [gadomski/virtualenv-py3.11]
         414±20μs         399±10μs     0.96  item.ItemBench.time_item_from_dict [gadomski/virtualenv-py3.11-orjson]
         781±80μs         726±40μs     0.93  item.ItemBench.time_item_from_file [gadomski/virtualenv-py3.11]
         644±30μs         628±40μs     0.98  item.ItemBench.time_item_from_file [gadomski/virtualenv-py3.11-orjson]
         917±70μs         857±20μs     0.93  item.ItemBench.time_item_save [gadomski/virtualenv-py3.11]
          246±9μs         242±20μs     0.98  item.ItemBench.time_item_save [gadomski/virtualenv-py3.11-orjson]
         22.8±2μs       21.8±0.7μs     0.96  item.ItemBench.time_item_to_dict [gadomski/virtualenv-py3.11]
         21.8±1μs       21.8±0.6μs     1.00  item.ItemBench.time_item_to_dict [gadomski/virtualenv-py3.11-orjson]

@gadomski gadomski marked this pull request as ready for review June 29, 2023 16:26
@gadomski gadomski requested a review from jsignell June 29, 2023 16:26
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gadomski gadomski added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit b62d5a5 Jun 30, 2023
@gadomski gadomski deleted the release/v1.8.0 branch June 30, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants