Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the validator before each test #1242

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Clear the validator before each test #1242

merged 1 commit into from
Sep 28, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Sep 27, 2023 •
edited
Loading

Description:

This lets call pass:

pytest tests/validation/test_validate.py

Before, cache changes in the validator would make some VCR tests fail. cc

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell September 27, 2023 21:28
@gadomski gadomski self-assigned this Sep 27, 2023
@gadomski gadomski marked this pull request as ready for review September 27, 2023 21:28
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pystac/validation/local_validator.py 58.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@gadomski
Copy link
Member Author

cc @chuckwondo

chuckwondo
chuckwondo approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Works like a charm now. Thanks!

@gadomski gadomski added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit aeafd98 Sep 28, 2023
@gadomski gadomski deleted the fix-isolated-tests branch September 28, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckwondo chuckwondo chuckwondo approved these changes

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gadomski @jsignell @chuckwondo